Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excessive memory leaking #11

Open
seiyria opened this issue Nov 20, 2015 · 5 comments
Open

excessive memory leaking #11

seiyria opened this issue Nov 20, 2015 · 5 comments
Assignees

Comments

@seiyria
Copy link

seiyria commented Nov 20, 2015

over time, if used for a really long time (8-36 hours) this causes a webpage to become incredibly slow. tested with and without on a project and the speed does not drop if hacktimer is not included.

@turuslan
Copy link
Owner

thank you for reporting.
i will try to find out and fix it.

@turuslan turuslan self-assigned this Nov 24, 2015
@timotheeg
Copy link

FYI: I reckon it's because the callback map is not cleared on successful setTimeout callback. For setTimeouts, the callback map should be cleared even if clearTimeout is not called explicitly.

turuslan added a commit that referenced this issue Dec 3, 2015
…cycle fake id to 31 bit unsigned integer range, prevent overwriting of active fake id.
@turuslan
Copy link
Owner

turuslan commented Dec 3, 2015

Thanks to @timotheeg, there was such a mistake of not deleting unused timeout entries. Commit e11f3ed must fix it.

@seiyria
Copy link
Author

seiyria commented Dec 3, 2015

I'll give this a try sometime later and see if it's still causing problems. If so, I'll let you know. Thanks!

@turuslan
Copy link
Owner

In commit e11f3ed I forgot to update silent version (HackTimer.silent.min.js) (issue 13) that you used (package.json).
So it was not fixed that time.
Now it is updated (8e2fef9, c06bbc6).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants