-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resumable uploads with GCS #183
Conversation
Clean up files after test. Don't depend of files being already on GCS storage.
Wow, thank you very much for this and your other PRs! We really appreciate the work you have put into these and into tus-node-server as a whole. Sadly, tus-node-server is currently and has been unmaintained for quite some time, after its original author stepped down. I also didn't have the time and experience to keep tus-node-server updated on my own, so I also lack the knowledge to proper review your PR and provide the feedback it deserves. Therefore, I would like to make you a little offer and invite you as a collaborator to tus-node-server. If you are interested you can develop the PRs of yours directly in the tus-node-server repository and give it some attention without the overhead of opening PRs and waiting for them to be merged. We would really like to see tus-node-server be in better shape since many people find it incredibly useful. And hopefully, you share the same vision! Of course, I will always be available for comments and questions, even though my knowledge of this code base is rather limited. Let me know what you think of this :) |
Thank you for you offer. I've accepted an invitation for collaboration. What is best channel for you to discuss future plans for this project? |
@Acconut I can't merge this PR because not all checks are completed. Look like something is wrong with |
Awesome, that is great to hear! Looking forward to working together :)
If we are talking about bigger decisions for tus-node-server, it would make sense to discuss them in the open on GitHub. Otherwise, for smaller questions about tus, I can invite you to our Slack channel. Just send me your email at marius@transloadit.com.
Yes, I removed the protection that PRs must have all checks passing before they can be merged. Let me know if that works now for you or you need further help. |
My solution is to write to temporary file on subsequent writes and combine with original file. Temporary file is discarded immediately after write.
I added test for this behavior and improved some other test. Many tests did not remove files after.
Resolves #37