Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resumable uploads with GCS #183

Merged
merged 6 commits into from
Jun 9, 2021
Merged

resumable uploads with GCS #183

merged 6 commits into from
Jun 9, 2021

Conversation

mitjap
Copy link
Collaborator

@mitjap mitjap commented May 27, 2021

My solution is to write to temporary file on subsequent writes and combine with original file. Temporary file is discarded immediately after write.

I added test for this behavior and improved some other test. Many tests did not remove files after.

Resolves #37

@Acconut
Copy link
Member

Acconut commented Jun 7, 2021

Wow, thank you very much for this and your other PRs! We really appreciate the work you have put into these and into tus-node-server as a whole. Sadly, tus-node-server is currently and has been unmaintained for quite some time, after its original author stepped down. I also didn't have the time and experience to keep tus-node-server updated on my own, so I also lack the knowledge to proper review your PR and provide the feedback it deserves.

Therefore, I would like to make you a little offer and invite you as a collaborator to tus-node-server. If you are interested you can develop the PRs of yours directly in the tus-node-server repository and give it some attention without the overhead of opening PRs and waiting for them to be merged. We would really like to see tus-node-server be in better shape since many people find it incredibly useful. And hopefully, you share the same vision! Of course, I will always be available for comments and questions, even though my knowledge of this code base is rather limited.

Let me know what you think of this :)

@mitjap
Copy link
Collaborator Author

mitjap commented Jun 8, 2021

Thank you for you offer. I've accepted an invitation for collaboration. What is best channel for you to discuss future plans for this project?

@mitjap
Copy link
Collaborator Author

mitjap commented Jun 8, 2021

@Acconut I can't merge this PR because not all checks are completed. Look like something is wrong with coverage/coveralls as it is pending for days or event longer in other PRs. For same reason I can not push directly to master branch. Is there anything you can do to resolve this?

@Acconut
Copy link
Member

Acconut commented Jun 9, 2021

Thank you for you offer. I've accepted an invitation for collaboration.

Awesome, that is great to hear! Looking forward to working together :)

What is best channel for you to discuss future plans for this project?

If we are talking about bigger decisions for tus-node-server, it would make sense to discuss them in the open on GitHub. Otherwise, for smaller questions about tus, I can invite you to our Slack channel. Just send me your email at marius@transloadit.com.

I can't merge this PR because not all checks are completed. Is there anything you can do to resolve this?

Yes, I removed the protection that PRs must have all checks passing before they can be merged. Let me know if that works now for you or you need further help.

@mitjap mitjap merged commit 698918b into tus:master Jun 9, 2021
@mitjap mitjap deleted the gcs-resumable branch June 9, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resuming PATCH requests override already uploaded GCS data
2 participants