-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pyproject.toml and cleanup non-source files #89
Conversation
We changed the `LICENSE` file so we need to update the hash
tusclient/__init__.py
Outdated
@@ -1 +1 @@ | |||
__version__ = '1.0.2' | |||
__version__ = '1.0.3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we are dropping support for older versions of python, this arguable should be a major (2.0.0) or minor (1.1.0) change rather than than a patch (1.0.x) change.
[project] | ||
name = "tuspy" | ||
description = "A Python client for the tus resumable upload protocol -> http://tus.io" | ||
authors = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is someone who is maintain the project that isn't the original author, they should consider adding themselves to the maintainers metadata.
dynamic = ["version"] | ||
|
||
[project.urls] | ||
Homepage = "http://tus-py-client.readthedocs.io/en/latest/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like the documentation online has been updated in over 5 years, I've set the metadata to point to this documentation as the homepage but maybe that's a bad idea.
@Acconut - I should add, a. it /might/ be better now that we know cause of the broken Windows tests that we scrap this particular PR because there's a lot of potentially breaking changes (due to specifying / narrowing types for instance) and instead we could do a bunch of smaller changes |
I haven't look thoroughly at this PR yet because it's a lot of changes, but I can answer the two recent questions.
I agree. It would make sense to fix the Windows tests in a separate PR and see how many of the improvements we can pursue in individual PRs before breaking backwards compatibility. All the other changes can then be done afterwards for a v2.
Yes, breaking changes will require a v2 release as we follow SemVer for all of our software :) If there are additional breaking changes, now will be a good time to make them. However, I don't know any changes out of my head that we had planned. |
In that case, probably don't worry about reviewing this PR, I'll break it up into a few (or more). May not be for a little while though - depends on what I'm working on. |
Fixes #56, #49.
In addition to moving to
pyproject.toml
format, I've made a few other fairly significant updates:CONTRIBUTORS
from the git history, removed theAUTHORS
file, and updatedLICENSE
to reference the contributors file since under the MIT Licence each contributor still maintains copyright over the code they added.README.md
.grip
tox.ini
, updatedpython-requires>=3.8
, added 3.12 to CI"x".format(...)
)Fingerprint.get_fingerprint
- now only acceptsBinaryIO
.StringIO
files.Test Plan
pyproject.toml
againstvalidate-pyproject
README.md
usinggrip
Questions / Discussion / Misc
Note
I strongly recommend this is merged using a squash commit (opposed to a merge or rebase - the commit history here is pretty garbage).