-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Mime Type returned #304
Comments
Pdfs word as expected |
Good finding! We currently (incorrectly) don't allow dots in the values for the Content-Type header, causing tusd to fall back to the default type of application/octet-stream.
This should never happen. Can you confirm that the file content is different using checksums (e.g. md5 or sha1)? |
I will reconfirm this is changing the checksum. Could be on our side. |
Yes they match. So thats all fine. |
Great, thanks for checking! I am going to close this issue since the incorrect mime type was fixed in 852b6fa which will be included in the next release. |
Thanks. Will use a custom image build until it’s realeased. |
Describe the bug
When uploading a Microsoft Word doc such as
.docx
tusd returns an incorrect mime header ofcontent-type: application/octet-stream
should be
content-type: application/vnd.openxmlformats-officedocument.wordprocessingml.document
This actually occurs for many file types. It actually seems to modify the actual file. Once we download it again and check the mime locally on a linux box its reading it wrong...
To Reproduce
Can reproduced on https://uppy.io/examples/dashboard/
Expected behavior
correct mime header
The text was updated successfully, but these errors were encountered: