-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker build process #511
Comments
Let me know if you need any help with this @Acconut. |
what about gitub registery ? |
Thank you very much for your offering, @omBratteng! That would be very helpful. I don't use Docker on a daily basis, so my knowledge regarding Docker is a bit rusty :) If I understand our current CI setup correctly, we already build the Docker image on GHA and push it to the registry using the last commit as the tag: tusd/.github/workflows/main.yml Lines 54 to 61 in 16a3747
This part seems to work fine, as I can see those tags, e.g. https://hub.docker.com/layers/tusproject/tusd/dd44267c082c98e99f08ca88ad85eb0b7fe93ef6/images/sha256-bf372cfa53e6c0314104cc9dcf66b28f7b6957a4276259a527239cfc507366ea?context=explore In that case, the only thing we need to do, is make the same image available under the
The GitHub registry is a possible improvement in the future. But as the Docker registry is the default for many developers, I would like to see an updated image on Docker Hub first :) |
@Acconut cool, I’ll try to have a PR ready tomorrow. |
@omBratteng Wow, that would be grand! |
Nice, I'll still probably come with a PR later that does multi-arch building, and better metadata on the image itself. |
Previously we used the Docker Build service to build the Docker images by Docker hub themselves. Since they changed their pricing, this feature is no longer available and the Docker images there are outdated: https://hub.docker.com/repository/docker/tusproject/tusd/tags?page=1&ordering=last_updated
Either we try to get a free subscription as an open-source project or build the Docker images on our own and push them to the registry.
The text was updated successfully, but these errors were encountered: