handler: Fix error with RUFH upload ending too soon #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a RUFH PATCH requests gets interrupted, the error is swallowed by the bodyReader. This is not a problem for tus uploads, but leads to issues with RUFH uploads because a successful RUFH PATCH request with Upload-Complete: ?1 will set the upload length. If an interrupted PATCH is thus interpreted as successful, it will cause the upload length to be set to the offset at which the upload was interrupted and thus preventing the upload from being resumed.
This PR fixes this problem by not swallowing the error, making the handler aware of the interruption.