Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: Correct hook type in plugin example #1101

Merged
merged 2 commits into from
Jun 14, 2024
Merged

examples: Correct hook type in plugin example #1101

merged 2 commits into from
Jun 14, 2024

Conversation

ehsansouri23
Copy link
Contributor

@ehsansouri23 ehsansouri23 commented Mar 31, 2024 •
edited
Loading

Correct comment in hook example

Acconut
Acconut approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for bringing this up! I believe the comment had the right intention, but the condition should check for post-finish. I quickly fixed that.

@Acconut Acconut changed the title Update hook_handler.go. Correct comment examples: Correct hook type in plugin example Jun 14, 2024
@Acconut Acconut merged commit fa5f966 into tus:main Jun 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acconut Acconut Acconut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehsansouri23 @Acconut