support object prefix on GCS object names #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acconut
reviewed
May 26, 2019
|
Thank you for this PR, it's looking very good. However, would you mind adding a test where an object prefix is defined? |
thanks for reviewing, and i already committed new change. |
Acconut
approved these changes
Jun 2, 2019
Acconut
pushed a commit
that referenced
this pull request
Jun 2, 2019
Squashed commit of the following:
commit e48ca3f3fe086504aa1a97d26e2f4fe263880664
Author: Marius <maerious@gmail.com>
Date: Sun Jun 2 15:54:39 2019 +0200
Format Go source code
commit 477ef68
Merge: 82c50f9 b89c337
Author: Ridho Azhar <azharridho42@gmail.com>
Date: Mon May 27 15:56:20 2019 +0700
Merge branch 'master' into master
commit 82c50f9
Author: ridhozhr <ridho@nodeflux.io>
Date: Mon May 27 13:30:57 2019 +0700
add test file with prefix
commit aa8a298
Author: ridhozhr <ridho@nodeflux.io>
Date: Mon May 27 13:18:08 2019 +0700
remove object prefix gcs from parameter
commit e25b36c
Author: ridhozhr <ridho@nodeflux.io>
Date: Wed May 22 22:19:01 2019 +0700
add flags gcs object prefix validation
commit 53762be
Author: ridhozhr <ridho@nodeflux.io>
Date: Wed May 22 22:04:17 2019 +0700
integrate prefix with store method
commit fe62533
Author: ridhozhr <ridho@nodeflux.io>
Date: Wed May 22 21:03:25 2019 +0700
add prefix in test file gcs store
commit e824008
Author: ridhozhr <ridho@nodeflux.io>
Date: Wed May 22 20:57:32 2019 +0700
integrate flags with composer gcs object prefix
commit bb2ee4c
Author: ridhozhr <ridho@nodeflux.io>
Date: Wed May 22 20:54:38 2019 +0700
add gcs-object-prefix flag
commit 600f4fc
Author: ridhozhr <ridho@nodeflux.io>
Date: Wed May 22 20:54:14 2019 +0700
add object prefix in gcs store
|
Thank you very much, this has been merged in 53b86ab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference : #213
since prefixing object name available in s3 object, i think its good to be able to prefix object name in gcs too.
thanks @acj for making that so i can replicate it for GCS store