Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopted change in prometheus client lib. #281

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

thirsch
Copy link
Contributor

@thirsch thirsch commented Jun 12, 2019

I was not able to build the docker container unless doing the changes contained in this pr. Is it correct? Has the handler been in another package before?

@Acconut
Copy link
Member

Acconut commented Jun 13, 2019

It seems correct, yes. As far as I can tell, prometheus.Handler was deprecated in favor of promhttp.Handler and got finally removed from Prometheus two days ago (see prometheus/client_golang@761a2ff#diff-b83b53c6fd7712ee815387960471957bL53). That's why you are likely the first person to notice this.

Your PR looks good and should fix it, thank you very much. We have plans to improve our dependency management in the future to prevent situations like this.

@Acconut Acconut merged commit c485127 into tus:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants