Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the docker user to tusd. #282

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Set the docker user to tusd. #282

merged 1 commit into from
Jun 13, 2019

Conversation

thirsch
Copy link
Contributor

@thirsch thirsch commented Jun 12, 2019

User tusd has been created but is not selected for the tusd process within the container. Fixed in this Dockerfile.

@kvz
Copy link
Member

kvz commented Jun 12, 2019

@kiloreux looks good to you?

@Acconut
Copy link
Member

Acconut commented Jun 13, 2019

Thank you for this change. I am not Docker expert so would you mind explaining if it's actually necessary to have a dedicated tusd user inside the Docker container? Does that provide a benefit or makes the setup just more complicated?

@kiloreux
Copy link
Contributor

Look good to me.
Basically we do this to limit permissions of the container process to that specific user instead of the default user (this one comes from the original image).

kiloreux
kiloreux approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@kiloreux kiloreux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Acconut Acconut merged commit a6ebba6 into tus:master Jun 13, 2019
@thirsch
Copy link
Contributor Author

thirsch commented Jun 19, 2019

@kiloreux, thanks for approving my pr. Who is managing the docker account? Looks like there is no autobuild in place, as the new version has not been built yet.

@Acconut
Copy link
Member

Acconut commented Jun 20, 2019

We manage the tusproject/tusd Docker image and it has autobuilds enabled but they are currently failing: https://cloud.docker.com/u/tusproject/repository/registry-1.docker.io/tusproject/tusd/builds/68adb8d5-e08e-4f0e-8630-1de78eb9e617

Since I don't have the time to look into this currently, would you mind giving the failing Docker build a try? That would help us a lot.

@thirsch
Copy link
Contributor Author

thirsch commented Jun 20, 2019

We manage the tusproject/tusd Docker image and it has autobuilds enabled but they are currently failing: https://cloud.docker.com/u/tusproject/repository/registry-1.docker.io/tusproject/tusd/builds/68adb8d5-e08e-4f0e-8630-1de78eb9e617

Since I don't have the time to look into this currently, would you mind giving the failing Docker build a try? That would help us a lot.

Thanks for your feedback. I'd be happy to help. Unfortunately, I'm only getting a 404. Maybe because I have no permissions to the repo? My username at docker hub is thirsch as well.

@Acconut
Copy link
Member

Acconut commented Jun 21, 2019

Unfortunately, I'm only getting a 404. Maybe because I have no permissions to the repo? My username at docker hub is thirsch as well.

Good call, thank you very much! I added you to tusproject/tusd, so you should be able to access the build output. Does it work for you now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiloreux kiloreux kiloreux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thirsch @kvz @Acconut @kiloreux