Installing gcc and libc-dev for having a matching gcc and linker in the image. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow the base image must have been changed in the last few days and the compiler and linker does not match against each other. By installation gcc and libc-dev manually, we can enforce the correct versions for the build process. Another option would have been to disable native compilation by setting CGO_ENABLED = 0. |
Acconut
approved these changes
Jun 24, 2019
|
Perfect, it's working now. Could you also apply a new version tag if the master is stable from your point of view or should we create a new branch for having 0.13.0 + the fixes as 0.13.1, because 0.13.0 couldn't be built on docker as well. |
|
Of course, the release is on its way: https://github.com/tus/tusd/releases/tag/0.13.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issues with the docker build process.