cli: add header forwarding in HTTP hooks #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acconut
requested changes
May 1, 2020
cmd/tusd/cli/flags.go
Outdated
| @@ -55,6 +56,7 @@ func ParseFlags() { | |||
| flag.StringVar(&Flags.EnabledHooksString, "hooks-enabled-events", "", "Comma separated list of enabled hook events (e.g. post-create,post-finish). Leave empty to enable all events") | |||
| flag.StringVar(&Flags.FileHooksDir, "hooks-dir", "", "Directory to search for available hooks scripts") | |||
| flag.StringVar(&Flags.HttpHooksEndpoint, "hooks-http", "", "An HTTP endpoint to which hook events will be sent to") | |||
| flag.StringVar(&Flags.HttpHooksForwardHeaders, "hooks-http-forward-headers", "", "List of HTTP request headers to include in hook request") | |||
There was a problem hiding this comment.
Please reword the description so it's apparent that the header values are forwarded from the client's requests.
Acconut
added a commit
that referenced
this pull request
May 15, 2020
* core: add new synchronous event: pre-finish * docs: pre-finish hook event * docs: Added information about CORS to the FAQ. (#384) * Added information about CORS to the FAQ. * docs: Expand explanation of CORS Co-authored-by: Marius <marius@transloadit.com> * cli: add header forwarding in HTTP hooks (#371) * cli: add header forwarding in HTTP hooks * docs: Reword header forwarding flag, add documentation * Don't enable pre-finish hooks by default * Enable pre-finish hooks for plugins * docs: default enabled hooks * Rename callback Co-authored-by: josh-marshall-jax <52457971+josh-marshall-jax@users.noreply.github.com> Co-authored-by: Marius <marius@transloadit.com>
justinruggles
pushed a commit
to vimeo/tusd
that referenced
this pull request
Oct 26, 2020
* cli: add header forwarding in HTTP hooks * docs: Reword header forwarding flag, add documentation
justinruggles
pushed a commit
to vimeo/tusd
that referenced
this pull request
Oct 26, 2020
* core: add new synchronous event: pre-finish * docs: pre-finish hook event * docs: Added information about CORS to the FAQ. (tus#384) * Added information about CORS to the FAQ. * docs: Expand explanation of CORS Co-authored-by: Marius <marius@transloadit.com> * cli: add header forwarding in HTTP hooks (tus#371) * cli: add header forwarding in HTTP hooks * docs: Reword header forwarding flag, add documentation * Don't enable pre-finish hooks by default * Enable pre-finish hooks for plugins * docs: default enabled hooks * Rename callback Co-authored-by: josh-marshall-jax <52457971+josh-marshall-jax@users.noreply.github.com> Co-authored-by: Marius <marius@transloadit.com>
justinruggles
pushed a commit
to vimeo/tusd
that referenced
this pull request
Oct 26, 2020
* cli: add header forwarding in HTTP hooks * docs: Reword header forwarding flag, add documentation
justinruggles
pushed a commit
to vimeo/tusd
that referenced
this pull request
Oct 26, 2020
* core: add new synchronous event: pre-finish * docs: pre-finish hook event * docs: Added information about CORS to the FAQ. (tus#384) * Added information about CORS to the FAQ. * docs: Expand explanation of CORS Co-authored-by: Marius <marius@transloadit.com> * cli: add header forwarding in HTTP hooks (tus#371) * cli: add header forwarding in HTTP hooks * docs: Reword header forwarding flag, add documentation * Don't enable pre-finish hooks by default * Enable pre-finish hooks for plugins * docs: default enabled hooks * Rename callback Co-authored-by: josh-marshall-jax <52457971+josh-marshall-jax@users.noreply.github.com> Co-authored-by: Marius <marius@transloadit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #369