fix(ci): build arm64 #848
Merged
fix(ci): build arm64 #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer Mac computers with their M1 chips use the ARM architecture [1]. Currently there is no docker image for postgraphile published to Docker Hub supporting the `arm64` platform, only for `amd64`. This commit adds compilation for an ARM image as well, so that developers on newer Mac computers can use postgraphile inside a container as well. [1] https://en.wikipedia.org/wiki/Apple_M1
4 tasks
|
In my testing it was not necessary to add a QEMU setup instruction to the ci script for this project. |
|
@Acconut anything I can help you with to get this merged? 🙌 |
|
Thanks as well! Would you mind pushing a |
|
@dargmuesli A new release is available: https://github.com/tus/tusd/releases/tag/v1.10.1 |
|
Great! Thank you very much @Acconut <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Newer Mac computers with their M1 chips use the ARM architecture [1]. Currently there is no docker image for postgraphile published to Docker Hub supporting the
arm64platform, only foramd64. This commit adds compilation for an ARM image as well, so that developers on newer Mac computers can use postgraphile inside a container as well.[1] https://en.wikipedia.org/wiki/Apple_M1
Performance impact
The build time will be longer. Especially cross-platform compilation for ARM will take longer than AMD compilation on AMD ci workers due to necessary QEMU virtualization.
Additional info
I chose
fixas the type, as it does not really add a new feature to tusd but adds a missing platform for Mac.