Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend cloning using HTTPS #884

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Recommend cloning using HTTPS #884

merged 2 commits into from
Jan 20, 2023

Conversation

zain-naveed
Copy link
Contributor

No description provided.

@Acconut
Copy link
Member

Acconut commented Jan 20, 2023

Why was it necessary to change the clone command for you?

Your version does not work for me:

$ git clone git@github.com/tus/tusd.git
fatal: repository 'git@github.com/tus/tusd.git' does not exist

@zain-naveed
Copy link
Contributor Author

i have to try to clone this repo but it not working yet then I try to clone this repo with this command

git clone https://github.com/tus/tusd.git

@Acconut
Copy link
Member

Acconut commented Jan 20, 2023

Could you explain your rationale behind this change? Is HTTPS better than SSH?

@zain-naveed
Copy link
Contributor Author

zain-naveed commented Jan 20, 2023 via email

@Acconut Acconut mentioned this pull request Jan 20, 2023
@Acconut Acconut changed the title Update installation.md Recommend cloning using HTTPS Jan 20, 2023
@Acconut
Copy link
Member

Acconut commented Jan 20, 2023

Makes sense. Some developers might not have set up cloning over SSH.

@Acconut Acconut merged commit bc2eb47 into tus:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants