Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #945

Closed
wants to merge 1 commit into from
Closed

fix typo #945

wants to merge 1 commit into from

Conversation

abetomo
Copy link

@abetomo abetomo commented May 26, 2023

Terminater ->
Terminator

@abetomo
fix typo
5305cb7 
Terminater ->
Terminator

Signed-off-by: abetomo <abe@enzou.tokyo>
@Acconut
Copy link
Member

Acconut commented Jun 5, 2023

Thank you for this PR, but the name Terminater was chosen on purpose to follow the naming conventions for Go interfaces: https://go.dev/doc/effective_go#interface-names Of course, could also have gone with Terminator at that time, but we now have this interface name and I think it is fine to keep it and avoid unneeded breaking changes.

Nevertheless, thank you very much for your effort here :)

@Acconut Acconut closed this Jun 5, 2023
@abetomo abetomo deleted the fix-typo branch June 6, 2023 05:27
@abetomo
Copy link
Author

abetomo commented Jun 6, 2023

Thanks for the review!
Understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abetomo @Acconut