feat(upload): support custom request #1474

Volankey · 2021-10-28T09:44:22Z

closes: #1389
先提一下，感觉 customRequest里面的参数需要再讨论一下

vercel · 2021-10-28T09:44:27Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/E69GawvJgywCd1E8fD6CGzfVHqb4
✅ Preview: https://naive-ui-git-fork-volankey-customrequest-tusimple.vercel.app

codecov · 2021-10-28T09:56:30Z

Codecov Report

Merging #1474 (d4adafe) into main (dd844bb) will decrease coverage by 0.16%.
The diff coverage is 4.76%.

❗ Current head d4adafe differs from pull request most recent head 83bdae4. Consider uploading reports for the commit 83bdae4 to get more accurate results

@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
- Coverage   64.88%   64.71%   -0.17%     
==========================================
  Files         886      886              
  Lines       17198    17181      -17     
  Branches     4072     4059      -13     
==========================================
- Hits        11159    11119      -40     
- Misses       5278     5299      +21     
- Partials      761      763       +2

Impacted Files	Coverage Δ
src/upload/src/interface.ts	`100.00% <ø> (ø)`
src/upload/src/Upload.tsx	`66.29% <4.76%> (-8.40%)`	⬇️
src/log/src/LogLine.tsx	`39.13% <0.00%> (-47.83%)`	⬇️
src/log/src/LogLoader.tsx	`57.14% <0.00%> (-42.86%)`	⬇️
src/log/src/Log.tsx	`41.30% <0.00%> (-3.27%)`	⬇️
src/date-picker/src/panel/daterange.tsx	`58.97% <0.00%> (-2.57%)`	⬇️
src/date-picker/src/panel/datetimerange.tsx	`58.13% <0.00%> (-2.33%)`	⬇️
src/_internal/scrollbar/src/ScrollBar.tsx	`42.75% <0.00%> (-0.37%)`	⬇️
src/_styles/common/dark.ts	`100.00% <0.00%> (ø)`
src/_styles/common/light.ts	`100.00% <0.00%> (ø)`
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd844bb...83bdae4. Read the comment docs.

07akioni · 2021-10-28T19:18:16Z

package.json

@@ -121,6 +121,7 @@
    "@types/lodash": "^4.14.170",
    "@types/lodash-es": "^4.17.4",
    "async-validator": "^4.0.1",
+    "axios": "^0.24.0",


能用 fetch 么？不想引入个依赖

fetch没有 onProgress 的功能

得依赖 xhr 而且大部分还都用的 axios，要不我在这个demo里面引一个axios 的 script 标签?

那也应该是放进 devDeps。

https://rollupjs.org/guide/en/#outputmanualchunks
研究一下这个，把 axios 单独开一个 chunk 出来（试试，未必最终要这么做，试好了先提上来）

@Volankey

这个放到了devDeps里面了，也单独拆了chunk

07akioni · 2021-10-28T19:22:12Z

src/upload/src/interface.ts

+  onProgress?: (e: ProgressEvent, file: FileInfo) => void
+  onFinish?: (e: ProgressEvent, file: FileInfo) => void
+  onError?: (e: ProgressEvent, file: FileInfo) => void


该必传的得必传，不要让用户判断空

src/upload/src/Upload.tsx

Volankey · 2021-11-02T08:07:53Z

好了 @07akioni ，不过 axios 引入得问题还得讨论一下

07akioni · 2021-11-01T16:48:54Z

package.json

@@ -121,6 +121,7 @@
    "@types/lodash": "^4.14.170",
    "@types/lodash-es": "^4.17.4",
    "async-validator": "^4.0.1",
+    "axios": "^0.24.0",


那也应该是放进 devDeps。

https://rollupjs.org/guide/en/#outputmanualchunks
研究一下这个，把 axios 单独开一个 chunk 出来（试试，未必最终要这么做，试好了先提上来）

@Volankey

07akioni · 2021-11-01T16:51:30Z

src/upload/src/interface.ts

+  withCredentials?: boolean
+  headers?: FuncOrRecordOrUndef
+  onProgress: (e: CustomUploadProgressEvent) => void
+  onFinish: (body?: T) => void


Suggested change

onFinish: (body?: T) => void

onFinish: (payload?: T) => void

考虑一下 body 存在的必要性，我没看出来

on-finish 事件

这里是把用户传进来的又传回去了？我觉得🈚️必要的样子

src/upload/src/interface.ts

src/upload/src/Upload.tsx

07akioni · 2021-11-01T16:56:17Z

src/upload/src/Upload.tsx

+      const event = {
+        body
+      }


为啥需要这个东西？body 是用户传来的，这样会搞乱 change 回调的类型，如果真的非常需要的话让用户用闭包做就好了。

inst.onFinish 需要 event

这个 event 可以传出去个空的，但是没必要用户传进来我们再丢出去吧？这样类型也不好看

07akioni · 2021-11-02T17:21:16Z

昨天 review 完忘了提交了，尴尬

CHANGELOG.en-US.md

07akioni · 2021-11-08T18:15:29Z

package.json

@@ -109,7 +109,8 @@
    "typescript": "^4.4.2",
    "vite": "^2.1.3",
    "vue": "^3.2.12",
-    "vue-router": "^4.0.5"
+    "vue-router": "^4.0.5",
+    "axios": "^0.24.0"


这个没解决呢

这个放到了devDeps里面了，也单独拆了chunk

src/upload/demos/enUS/index.demo-entry.md

src/upload/demos/zhCN/index.demo-entry.md

src/upload/demos/enUS/index.demo-entry.md

07akioni · 2021-11-08T18:21:10Z

src/upload/demos/zhCN/index.demo-entry.md

+  data?: FuncOrRecordOrUndef
+  withCredentials?: boolean
+  headers?: FuncOrRecordOrUndef
+  onProgress: (e: {percent: number}) => void


Suggested change

onProgress: (e: {percent: number}) => void

onProgress: (e: { percent: number }) => void

src/upload/src/interface.ts

07akioni · 2021-11-08T18:23:11Z

src/upload/src/interface.ts

+  headers?: FuncOrRecordOrUndef
+  onProgress: (e: CustomUploadProgressEvent) => void
+  onFinish: () => void
+  onError: (error: ProgressEvent) => void


我感觉这里也不是必须要 error 这个参数，这个 onError 是我们传给用户的，我们依赖用户的从 onError 传回来的东西吗？感觉并不需要

07akioni · 2021-11-14T17:44:21Z

@JiwenBai

07akioni · 2021-11-14T17:44:25Z

@Volankey

Co-authored-by: 07akioni <07akioni2@gmail.com>

Volankey · 2021-11-24T06:49:26Z

好了 @07akioni

07akioni · 2021-11-24T14:32:55Z

src/upload/src/interface.ts

+export interface CustomUploadProgressEvent {
+  percent: number
+}


Suggested change

export interface CustomUploadProgressEvent {

percent: number

}

src/upload/src/interface.ts

07akioni · 2021-11-28T15:15:06Z

src/upload/src/Upload.tsx

+    method,
+    customRequest
+  } = options
+  const { doChange, XhrMap } = options.inst


XhrMap 要这个干啥子呢

这不是自定义逻辑吗？

07akioni · 2021-11-28T15:41:02Z

完整改动参考 ddb2326

vercel bot deployed to Preview October 28, 2021 09:44 View deployment

07akioni reviewed Oct 28, 2021

View reviewed changes

vercel bot deployed to Preview November 1, 2021 11:46 View deployment

vercel bot deployed to Preview November 2, 2021 08:03 View deployment

Volankey force-pushed the customRequest branch from 2fe4a63 to f7b5406 Compare November 2, 2021 08:06

Volankey changed the title ~~feat(upload): support custom request (WIP)~~ feat(upload): support custom request Nov 2, 2021

vercel bot deployed to Preview November 2, 2021 08:07 View deployment

07akioni reviewed Nov 2, 2021

View reviewed changes

CHANGELOG.en-US.md Outdated Show resolved Hide resolved

Volankey force-pushed the customRequest branch from f7b5406 to 0ed31b5 Compare November 3, 2021 09:23

vercel bot deployed to Preview November 3, 2021 09:23 View deployment

vercel bot deployed to Preview November 3, 2021 09:26 View deployment

07akioni reviewed Nov 8, 2021

View reviewed changes

RobotVol added 9 commits November 24, 2021 14:31

feat(upload): support custom request

6cc99a7

optimazitaion

a03cf42

feat(upload): custom request finished

267434f

feat(upload): update doc

3824c8b

feat(upload): update changelog

0976cb6

optimazition

bed1ab7

update change log

c16fd23

optimazition

752ae7f

update changelog

6ed7cb8

Volankey force-pushed the customRequest branch from a742c41 to 6ed7cb8 Compare November 24, 2021 06:36

vercel bot deployed to Preview November 24, 2021 06:37 View deployment

RobotVol added 2 commits November 24, 2021 14:38

update changelog

77b4d29

update changelog

2b69e4c

vercel bot deployed to Preview November 24, 2021 06:43 View deployment

Volankey and others added 2 commits November 24, 2021 14:44

Update src/upload/demos/enUS/index.demo-entry.md

3e57498

Co-authored-by: 07akioni <07akioni2@gmail.com>

Update src/upload/demos/zhCN/index.demo-entry.md

036f23e

Co-authored-by: 07akioni <07akioni2@gmail.com>

vercel bot deployed to Preview November 24, 2021 06:48 View deployment

Merge branch 'main' into customRequest

668ed6a

vercel bot deployed to Preview November 24, 2021 06:53 View deployment

Merge branch 'main' into customRequest

d4adafe

vercel bot deployed to Preview November 24, 2021 06:59 View deployment

07akioni reviewed Nov 24, 2021

View reviewed changes

Merge branch 'main' into customRequest

83bdae4

vercel bot deployed to Preview November 28, 2021 15:03 View deployment

07akioni merged commit 9fcc915 into tusen-ai:main Nov 28, 2021

07akioni reviewed Nov 28, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(upload): support custom request #1474

feat(upload): support custom request #1474

Volankey commented Oct 28, 2021

vercel bot commented Oct 28, 2021 •

edited

Loading

codecov bot commented Oct 28, 2021 •

edited

Loading

07akioni Oct 28, 2021

Volankey Nov 1, 2021

Volankey Nov 1, 2021

07akioni Nov 1, 2021 •

edited

Loading

Volankey Nov 24, 2021

07akioni Oct 28, 2021

Volankey commented Nov 2, 2021

07akioni Nov 1, 2021 •

edited

Loading

07akioni Nov 1, 2021

07akioni Nov 1, 2021

Volankey Nov 3, 2021

07akioni Nov 3, 2021

07akioni Nov 1, 2021

Volankey Nov 3, 2021

07akioni Nov 3, 2021 •

edited

Loading

07akioni commented Nov 2, 2021

07akioni Nov 8, 2021

07akioni Nov 24, 2021

Volankey Nov 25, 2021

07akioni Nov 8, 2021

07akioni Nov 8, 2021

07akioni commented Nov 14, 2021

07akioni commented Nov 14, 2021

Volankey commented Nov 24, 2021

07akioni Nov 24, 2021

07akioni Nov 28, 2021

07akioni Nov 28, 2021

07akioni commented Nov 28, 2021 •

edited

Loading

	onProgress: (e: {percent: number}) => void
	onProgress: (e: { percent: number }) => void

	export interface CustomUploadProgressEvent {
	percent: number
	}

feat(upload): support custom request #1474

feat(upload): support custom request #1474

Conversation

Volankey commented Oct 28, 2021

vercel bot commented Oct 28, 2021 • edited Loading

codecov bot commented Oct 28, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

07akioni Nov 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Volankey commented Nov 2, 2021

07akioni Nov 1, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

07akioni Nov 3, 2021 • edited Loading

Choose a reason for hiding this comment

07akioni commented Nov 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

07akioni commented Nov 14, 2021

07akioni commented Nov 14, 2021

Volankey commented Nov 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

07akioni commented Nov 28, 2021 • edited Loading

vercel bot commented Oct 28, 2021 •

edited

Loading

codecov bot commented Oct 28, 2021 •

edited

Loading

07akioni Nov 1, 2021 •

edited

Loading

07akioni Nov 1, 2021 •

edited

Loading

07akioni Nov 3, 2021 •

edited

Loading

07akioni commented Nov 28, 2021 •

edited

Loading