Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popconfirm): add negative-button-props and positive-button-props props #2648

Merged
merged 2 commits into from
Mar 20, 2022
Merged

feat(popconfirm): add negative-button-props and positive-button-props props #2648

merged 2 commits into from
Mar 20, 2022

Conversation

XieZongChen
Copy link
Collaborator

close #2642

@vercel
Copy link

vercel bot commented Mar 17, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/DUz6iAKJ4MPMot3nw8nr4TTnLtQR
✅ Preview: https://naive-ui-git-fork-amadeus711-feat-npopconfirm-a-6b82a3-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2648 (b92bfd2) into main (424e9cf) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b92bfd2 differs from pull request most recent head 306ddf5. Consider uploading reports for the commit 306ddf5 to get more accurate results

@@            Coverage Diff             @@
##             main    #2648      +/-   ##
==========================================
- Coverage   63.41%   63.40%   -0.01%     
==========================================
  Files         968      966       -2     
  Lines       19646    19631      -15     
  Branches     5069     5067       -2     
==========================================
- Hits        12459    12448      -11     
+ Misses       5872     5866       -6     
- Partials     1315     1317       +2     
Impacted Files Coverage Δ
src/popconfirm/src/Popconfirm.ts 74.19% <ø> (+3.60%) ⬆️
src/popconfirm/src/PopconfirmPanel.tsx 79.48% <ø> (ø)
src/dynamic-tags/src/DynamicTags.tsx 72.41% <0.00%> (-2.30%) ⬇️
src/popselect/src/Popselect.tsx 78.26% <0.00%> (-0.91%) ⬇️
src/locales/index.ts 100.00% <0.00%> (ø)
src/select/src/Select.tsx 36.74% <0.00%> (ø)
src/input/src/interface.ts 100.00% <0.00%> (ø)
src/mention/src/Mention.tsx 58.62% <0.00%> (ø)
src/cascader/src/Cascader.tsx 37.96% <0.00%> (ø)
src/popselect/src/interface.ts 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424e9cf...306ddf5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add type (i.e. color) to popconfirm buttons
2 participants