Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image descriptions are displayed as white text on dark background in light mode #2983

Closed
1 task done
magicalskye opened this issue Dec 4, 2022 · 1 comment · Fixed by #3003
Closed
1 task done

Image descriptions are displayed as white text on dark background in light mode #2983

magicalskye opened this issue Dec 4, 2022 · 1 comment · Fixed by #3003

Comments

@magicalskye
Copy link

Like many other people with a variety of visual disabilities, I have to use apps in light mode because I am unable to read light text on dark background. For this same reason I also depend on the ability to read the image description if someone posts a screenshot of text in a dark mode app. Currently tusky offers no way for me to read the image description at all, because I cannot read light text on dark background.

  • Tusky Version: 20.0

  • Android Version: 12

  • Android Device: Galaxy Tab A8

  • Mastodon instance (if applicable):

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.
@nikclayton
Copy link
Contributor

Thanks for the report. PR #3003 is in progress to fix this.

connyduck added a commit that referenced this issue Dec 6, 2022
@connyduck
Use light/dark mode colors for image description text (#3003)
08642d7 
* Use light/dark mode colors for image description text

This is an accessibility issue -- in light mode (which should have dark text
on a light background) the text color was hardcoded to light grey and the
background color was a semi-transparent black.

Fixes #2983.

* Update app/src/main/res/drawable/ic_drag_indicator_horiz_24dp.xml

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use light/dark mode colors for image description text
2 participants
@nikclayton @magicalskye