Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Generate mock data for the live route #633

Closed
wants to merge 12 commits into from

Conversation

clodaghwalsh17
Copy link

Please check if the PR fulfills these requirements

  • The commit message is sensible and easily understood
  • Tests for the changes have been added (for bug fixes / features where relevant)
  • Docs have been added / updated (for bug fixes / features where relevant)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Randomly generate data for the live route. This features mocks the act of a student logging into Tutors and browsing a course.

What commits does this PR relate to?

Lastest commit SHA ba15e0a
Last commit SHA 8568e3f

Thank you for your contribution

We hope you stay around and connect with our growing community!

clodaghwalsh17 and others added 11 commits January 18, 2024 14:38
Update the live page to display fake users

Signed-off-by: Clodagh Walsh <clodaghwalsh17@gmail.com>
Signed-off-by: Clodagh Walsh <clodaghwalsh17@gmail.com>
Signed-off-by: Clodagh Walsh <clodaghwalsh17@gmail.com>
… live page with course and resource within that choosen course

Signed-off-by: Clodagh Walsh <clodaghwalsh17@gmail.com>
Signed-off-by: Clodagh Walsh <clodaghwalsh17@gmail.com>
Signed-off-by: Clodagh Walsh <clodaghwalsh17@gmail.com>
Signed-off-by: Clodagh Walsh <clodaghwalsh17@gmail.com>
Copy link

netlify bot commented Jan 18, 2024

‼️ Deploy request for tutors-dev rejected.

Name Link
🔨 Latest commit ba15e0a

Copy link

netlify bot commented Jan 18, 2024

Deploy Preview for redirect-tutors-reader canceled.

Name Link
🔨 Latest commit cb90c32
🔍 Latest deploy log https://app.netlify.com/sites/redirect-tutors-reader/deploys/65a960b263ee380007c5e6eb

@ghost
Copy link

ghost commented Jan 18, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@edeleastar
Copy link
Contributor

@clodaghwalsh17 - great work Clodagh.
You may see that I have reorgansed the tutors repo - removing the mono repo and simplifing. The generators and other tools have been moved out to a new fork - tutors-apps.
Can I make a suggestion? The excellent work on the simultor would live better in tutors-apps as a standalone sveltekita app (tutors-apps is a monoorepo). This would fit better I think, keeping the tutors repo focussed, and growing a set of tools in tutors-app. Happy to do a call to discuss.

@edeleastar
Copy link
Contributor

edeleastar commented Jan 26, 2024

Thanks @clodaghwalsh17

I have refactored and integrated the simulator in a separate branch:

This is a great addition - thanks to all the team for the work!

@edeleastar edeleastar closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants