Etherpad-Lite: Support docker-compose, fix JSON #19
Conversation
|
Btw, what is the benefit of removing the apt source lists with From what I understand, the image isn't getting substantially smaller because the files will be kept in the layers below. |
- Support docker-compose added to Etherpad-Lite with pre-configured database - JSON creation fixed: If ETHERPAD_ADMIN_PASSWORD was not set, a trailing comma after the dbSettings was left. (1) Double quotation marks need escape. (2) settings.json is now created by node-js as ECMA- script supports JSON formatting natively. - Customizable database port through `ETHERPAD_DB_PORT`. - BEHAVIOUR CHANGE: Wait for mysql to become ready at specified host and port. This allows starting the containers with a single `docker-compose up`. Etherpad container won't exit if database connec- tion can't be established.
|
I think a fork is better suited. Merge request has issues. Thanks for your work! |
|
Hello, Thanks for all your comments. I will take a look in your fork, and eventually merge back any improvements. Cheers. |
|
Btw, regarding /var/lib/apt/lists/*, the removal is done under the same RUN directive that populates these files. Under tis scenario, the files will not kept in any of the layers (it is one layer per Dockerfile command). This is standard practice when writing Dockerfiles, even the official images use this (the official Wordpress image, for example https://github.com/docker-library/wordpress/blob/master/Dockerfile-debian.template ) |
ETHERPAD_DB_PORT.