Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zypper support #130

Closed
wants to merge 1 commit into from
Closed

add zypper support #130

wants to merge 1 commit into from

Conversation

adamcstephens
Copy link

@adamcstephens adamcstephens commented Dec 23, 2020

What is the name of the package manager you would like to see support for?

zypper

What operating systems or derivative does this package manager support?

  • Windows
  • Mac
  • Linux
  • BSD
  • Redox
  • iOS
  • Android
  • Other, namely:

If Linux, is it only for a specific distro?

  • Yes, namely: opensuse
  • No

What type of package manager is this?

  • Programming language specific (e.g. Cargo for Rust)
  • General purpose (e.g. APT on Debian)
  • Other, namely:

Are administrator priviliges required? (sudo, etc.)

  • Yes
  • No

I took a stab at adding zypper support, but it's not fully working. Zypper supports a shortened version in in place of install, which is successfully captured for most of the test cases. Unfortunately, it's also matching and being removed from packages with in in them.

---- package_manager::zypper::tests::test_catch stdout ----
thread 'package_manager::zypper::tests::test_catch' panicked at 'assertion failed: `(left == right)`
  left: `"linux-perf-5.3"`,
 right: `"lux-perf-5.3"`: Package "lux-perf-5.3" should be matched, but it's not', src/package_manager/zypper.rs:64:9

Any ideas on a fix?

@tversteeg
Copy link
Owner

Thanks for the effort! This is a deeper problem that's unrelated to your PR, can you create a bug issue for it? That way I can pick it up later.

@tversteeg
Copy link
Owner

Fixed the bug, if you can fix the TODO's in the implementation I can merge it!

@jayvdb
Copy link

jayvdb commented Mar 16, 2021

@adamcstephens @tversteeg what is left to be done here?

@tversteeg
Copy link
Owner

The flags that should be ignored and flags that should be captured need to be added.

@adamcstephens
Copy link
Author

I've mostly moved on from using zypper, so will probably not pick this back up. I also wasn't super excited to populate a bunch of flags from zypper into this, given that multiple other package manager don't have them either.

I'm closing, but I'll leave my branch up if someone wants to copy what I have so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants