webui: fix http_serve_file() for FreeBSD #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes two major problems of FreeBSD port of tvheadend: 1. very high CPU usage while streaming a recored program 2. unable to stream the recorded program beyond 128MB. Unlike Linux sendfile(), FreeBSD sendfile() requires an explicit file offset, and return value must be checked to catch any error occurred. (i.e., closed connection) Patch tested with the latest FreeBSD port of tvheadend-4.2.6.
|
Thank you!
2018-06-08 1:15 GMT+09:00 perexg <notifications@github.com>:
… Merged #1125 <#1125>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1125 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABmvO33ivcLtEsh13dh1Rfs1Z-irFyKqks5t6VGpgaJpZM4UQgPb>
.
|
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jun 13, 2018
1. very high CPU usage while streaming a recored program 2. unable to stream the recorded program beyond 128MB. Unlike Linux sendfile(), FreeBSD sendfile() requires an explicit file offset, and return value must be checked to catch any error occurred. (i.e., closed connection) Obtained from: tvheadend/tvheadend#1125 Submitted by: Jongsung Kim <jongsung.kim@gmail.com> git-svn-id: svn+ssh://svn.freebsd.org/ports/head@472317 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jun 13, 2018
1. very high CPU usage while streaming a recored program 2. unable to stream the recorded program beyond 128MB. Unlike Linux sendfile(), FreeBSD sendfile() requires an explicit file offset, and return value must be checked to catch any error occurred. (i.e., closed connection) Obtained from: tvheadend/tvheadend#1125 Submitted by: Jongsung Kim <jongsung.kim@gmail.com>
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Jun 13, 2018
1. very high CPU usage while streaming a recored program 2. unable to stream the recorded program beyond 128MB. Unlike Linux sendfile(), FreeBSD sendfile() requires an explicit file offset, and return value must be checked to catch any error occurred. (i.e., closed connection) Obtained from: tvheadend/tvheadend#1125 Submitted by: Jongsung Kim <jongsung.kim@gmail.com> git-svn-id: svn+ssh://svn.freebsd.org/ports/head@472317 35697150-7ecd-e111-bb59-0022644237b5
swills
pushed a commit
to swills/freebsd-ports
that referenced
this pull request
Jun 13, 2018
1. very high CPU usage while streaming a recored program 2. unable to stream the recorded program beyond 128MB. Unlike Linux sendfile(), FreeBSD sendfile() requires an explicit file offset, and return value must be checked to catch any error occurred. (i.e., closed connection) Obtained from: tvheadend/tvheadend#1125 Submitted by: Jongsung Kim <jongsung.kim@gmail.com> git-svn-id: svn+ssh://svn.freebsd.org/ports/head@472317 35697150-7ecd-e111-bb59-0022644237b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes two major problems of FreeBSD port of tvheadend:
Unlike Linux sendfile(), FreeBSD sendfile() requires an explicit
file offset, and return value must be checked to catch any error
occurred. (i.e., closed connection)
Patch tested with the latest FreeBSD port of tvheadend-4.2.6.