Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow popper to receive zIndex from user settings #129

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

anhvy
Copy link
Collaborator

@anhvy anhvy commented Jan 31, 2020

By default, react-tippy set tippy-popper's z-index to 9999, this change will allow user to pass their own value.
Example:

<Tooltip
  useContext
  position="bottom-end"
  trigger="manual"
  theme="dark-info"
  html={<NotificationList closeActivityFeed={closeActivityFeed} />}
  interactive
  arrow
  arrowSize="big"
  distance={15}
  offset={30}
  open={tooltipOpenState}
  onRequestClose={closeActivityFeed}
  zIndex={10000}
>
  <div style={styles.tooltipTrigger} onClick={openActivityFeed}>
    <Icon name="ui-1_bell-53" style={styles.bellIcon} />
    {counter > 0 && (
      <Badge type="danger" text={counter} style={styles.countBadge} />
    )}
  </div>
</Tooltip>

@tvkhoa tvkhoa merged commit f123696 into master Feb 2, 2020
@anhvy anhvy mentioned this pull request Feb 24, 2020
rtalexk added a commit to rtalexk/react-tippy that referenced this pull request Aug 20, 2021
`zIndex` prop was introduced in this PR tvkhoa#129 but it was not included in the type definitions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants