Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce backwards compatibility in favor of more logical edits #1

Conversation

tvquizphd
Copy link
Owner

@tvquizphd tvquizphd commented Jan 9, 2021

This is a PR against the existing wooorm/nspell PR #39. It's an attempt to further address the broken keyboard group logic I've discovered with nspell.

Please have a look at the files changed. I've framed these edits in a way that shows how this PR makes more sense when thinking about how "keyboard group replacement" should operate.

The base branch passes all but one test by keeping part of the broken keyboard logic

This PR fails three tests, but uses "correct" keyboard logic

  • Fixes the capitalization issue
  • Fixes the short-word problem
  • Fixes the long-word problem
  • Benignly Fails test #46
    • the output is [ 'Brandi', 'Ghana', 'Grandee', 'Shanxi', 'hand', 'hands', 'handy' ]
  • Benignly Fails tests #45 and #53
    • by weighing proper over dropper for input propper
    • by weighing colloq over color for input collor

@tvquizphd tvquizphd merged commit 31e340d into fix_extra_uppercase_root_problem Jan 9, 2021
@tvquizphd tvquizphd deleted the fix_extra_uppercase_root_problem_alt branch January 9, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant