add regex bulk_extractor option #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Joe, thanks for the PR! From a quick glance this looks good, but I will take a closer look later this week. I can definitely include this in the next release! (given the scope of what's going in, it's now looking like this might be 1.9.0 rather than 1.8.2). |
|
LGTM! I'm merging this into the dev branch and will include it in the next release. Thanks again @jfcarrano ! |
|
Awesome! Thanks for continuing to maintain this! |
|
Hi @jfcarrano, just a quick note to say that I just released Brunnhilde 1.9.0, with this new feature included: https://github.com/tw4l/brunnhilde/releases/tag/v1.9.0. You should be able to update with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Tessa,
I took the regex bulk_extractor option code from br_processor.py within Bulk Reviewer and added it here. It seems to work with limited testing. I think it will be useful for my (and maybe others?) situation of running brunnhilde (and dependent CCA tools) prior to using Bulk Reviewer with pre-existing reports. Hopefully that makes sense!