Order of arguments integrate func #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your fixes/additions/changes
This PR addresses Issue #9: the names of the states and parameters defined by the user in his/her model class had to provided in exactly the same order in the integrate/compute_rates function defined by the user. By providing the parameters and states internally as keyworded arguments to the integrate/compute_rates function, this need has been relaxed.
However, the user should still make sure the differentials of his
integratefunction (for ODEs) match the order of the state names provided. I choose not to return the differentials as a dictionary (for now), as I still have to figure out if using dictionaries with numba is sufficiently easy.