Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix word-wrap in navigation bar #152

Closed
wants to merge 2 commits into from
Closed

Fix word-wrap in navigation bar #152

wants to merge 2 commits into from

Conversation

manan30
Copy link

@manan30 manan30 commented Jul 2, 2020

Link breaks on some browsers (Opera) when styled with word-break. It causes the text to overflow to the next line. This fix removes the style that causes the issue.

Fixes #151

@manan30 manan30 changed the title Fix/issue 151 Fix/issue 151: word-wrap in navigation bar Jul 2, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Jul 3, 2020

@MartijnCuppens I remember we added this to prevent links going out of view.

@XhmikosR XhmikosR changed the title Fix/issue 151: word-wrap in navigation bar Fix word-wrap in navigation bar Jul 8, 2020
@XhmikosR XhmikosR requested a review from mdo July 8, 2020 13:51
@XhmikosR
Copy link
Member

XhmikosR commented Jul 8, 2020

  1. there shouldn't be commented out code
  2. We added this explicitly to prevent long links from overflowing the page, which means this will re-introduce the issue, see Break long links in posts #81

@manan30
Copy link
Author

manan30 commented Jul 8, 2020

  1. there shouldn't be commented out code
  2. We added this explicitly to prevent long links from overflowing the page, which means this will re-introduce the issue, see Break long links in posts #81

I did not understand the screenshot on #80. Can you please explain more about that?

@mdo
Copy link
Member

mdo commented Jul 11, 2020

Closing for #154.

@mdo mdo closed this Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word-Wrap in navigation bar on the bootstrap blog
3 participants