Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve banner partial #294

Merged
merged 4 commits into from
Jul 15, 2022
Merged

Improve banner partial #294

merged 4 commits into from
Jul 15, 2022

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jul 14, 2022 •
edited
Loading

  • lazyload banner image (not perfect if it's the first post, but it's a compromise we need to make)
  • add dimensions (we should always add dimensions to prevent reflows)

@XhmikosR XhmikosR changed the title WIP Improve banner partial Jul 14, 2022
@XhmikosR XhmikosR marked this pull request as ready for review July 14, 2022 06:35
XhmikosR
XhmikosR commented Jul 14, 2022
View reviewed changes
src/layouts/partials/banner.html
{{- $image := .context.Page.Params.banner -}}
{{- $src := .context.Page.Params.banner -}}
{{- $config := imageConfig (add "/src/static" $src) -}}
{{- $classes := "d-block img-fluid rounded-3 mb-4" -}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if we can now remove any CSS we may have, I'll leave this to you @mdo :)

@XhmikosR XhmikosR merged commit 7fa6290 into main Jul 15, 2022
@XhmikosR XhmikosR deleted the XhmikosR-patch-2 branch July 15, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XhmikosR