Removed stray 100% from vertical-three-colours mixin #222

Merged
merged 1 commit into from Oct 16, 2012

Conversation

Projects
None yet
2 participants
@jasononeil
Contributor

jasononeil commented Oct 2, 2012

In the gradient-vertical-three-colours mixin, the mozilla specific call multiplied the colour stop by 100%. This was not present in the original bootstrap mixin(1) and was not present in bootstrap-sass 2.0.4.0. The mozilla documentation also does not indicate any difference in syntax is necessary (2)

Before my edit, we were getting errors such as:

7000%*% isn't a valid CSS value.

when using the mixin. With my edit the mixin functions correctly. Would it be possible to accept this patch and update the Gem?

Thanks heaps,
Jason O'Neil

(1) https://github.com/twitter/bootstrap/blob/master/less/mixins.less
(2) https://developer.mozilla.org/en-US/docs/CSS/linear-gradient?redirectlocale=en-US&redirectslug=CSS%2F-moz-linear-gradient#Cross-browser_gradients

Removed stray 100% from vertical-three-colours mixin
In the gradient-vertical-three-colours mixin, the mozilla specific call multiplied the colour stop by 100%.  This was not present in the original bootstrap mixin(1) and was not present in bootstrap-sass 2.0.4.0.  The mozilla documentation also does not indicate any difference in syntax is necessary (2)

Before my edit, we were getting errors such as:

> 7000%*% isn't a valid CSS value.

when using the mixin.  With my edit the mixin functions correctly.  Would it be possible to accept this patch and update the Gem?

Thanks heaps,
Jason O'Neil

(1) https://github.com/twitter/bootstrap/blob/master/less/mixins.less
(2) https://developer.mozilla.org/en-US/docs/CSS/linear-gradient?redirectlocale=en-US&redirectslug=CSS%2F-moz-linear-gradient#Cross-browser_gradients

thomas-mcdonald added a commit that referenced this pull request Oct 16, 2012

Merge pull request #222 from jasononeil/patch-1
Removed stray 100% from vertical-three-colours mixin

@thomas-mcdonald thomas-mcdonald merged commit 3877c38 into twbs:master Oct 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment