Removed stray 100% from vertical-three-colours mixin #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the gradient-vertical-three-colours mixin, the mozilla specific call multiplied the colour stop by 100%. This was not present in the original bootstrap mixin(1) and was not present in bootstrap-sass 2.0.4.0. The mozilla documentation also does not indicate any difference in syntax is necessary (2) Before my edit, we were getting errors such as: > 7000%*% isn't a valid CSS value. when using the mixin. With my edit the mixin functions correctly. Would it be possible to accept this patch and update the Gem? Thanks heaps, Jason O'Neil (1) https://github.com/twitter/bootstrap/blob/master/less/mixins.less (2) https://developer.mozilla.org/en-US/docs/CSS/linear-gradient?redirectlocale=en-US&redirectslug=CSS%2F-moz-linear-gradient#Cross-browser_gradients
thomas-mcdonald
added a commit
that referenced
this pull request
Oct 16, 2012
Removed stray 100% from vertical-three-colours mixin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the gradient-vertical-three-colours mixin, the mozilla specific call multiplied the colour stop by 100%. This was not present in the original bootstrap mixin(1) and was not present in bootstrap-sass 2.0.4.0. The mozilla documentation also does not indicate any difference in syntax is necessary (2)
Before my edit, we were getting errors such as:
when using the mixin. With my edit the mixin functions correctly. Would it be possible to accept this patch and update the Gem?
Thanks heaps,
Jason O'Neil
(1) https://github.com/twitter/bootstrap/blob/master/less/mixins.less
(2) https://developer.mozilla.org/en-US/docs/CSS/linear-gradient?redirectlocale=en-US&redirectslug=CSS%2F-moz-linear-gradient#Cross-browser_gradients