Puts @font-face and @-ms-viewport at root of CSS #805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is valid, but needs to be done at the converter level |
|
Turns out nested |
|
Sorry, could you clarify where it says that @font-face is valid? I couldn't find it in the link. I also couldn't get a nested @font-face to validate on http://jigsaw.w3.org/css-validator/ |
|
@glebm Where in that issue do they say it's valid CSS? |
|
They don't, I must have misread something. Looking at mozilla docs, |
glebm
added a commit
that referenced
this pull request
Apr 27, 2015
ElMassimo
pushed a commit
to SolarCS/bootstrap-sass
that referenced
this pull request
Apr 11, 2017
ElMassimo
pushed a commit
to SolarCS/bootstrap-sass
that referenced
this pull request
Apr 11, 2017
As of version 3.3.5, the @at-root sass feature has been introduced: twbs#805 twbs@2579e33 This feature depends on sass >= 3.3. * Bump minimum sass version * Remove sass 3.2 gemfile and update tests See also: twbs#920
bluedone
added a commit
to bluedone/bootstrap-rubygem
that referenced
this pull request
Jun 6, 2023
As of version 3.3.5, the @at-root sass feature has been introduced: twbs/bootstrap-sass#805 twbs/bootstrap-sass@2579e33 This feature depends on sass >= 3.3. * Bump minimum sass version * Remove sass 3.2 gemfile and update tests See also: twbs/bootstrap-sass#920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nested bootstrap sass import produces invalid CSS.
allows you to contain all the bootstrap styles, except it nests @font-face and @-ms-viewport, which need to be declared at the root.
I understand that this is a straight conversion from less, but since less doesn't support @at-root, this seems to be the best place to do this.