Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizer URL problem #11317

Closed
Studio384 opened this issue Oct 31, 2013 · 6 comments · Fixed by #11336
Closed

Customizer URL problem #11317

Studio384 opened this issue Oct 31, 2013 · 6 comments · Fixed by #11336

Comments

@Studio384
Copy link

When you use the Customizer and hit the "Compile and Download" button, the menu breaks.

@cvrebert
Copy link
Collaborator

What do you mean by "the menu"?

@Studio384
Copy link
Author

The navbar on top of the page, the links are relative, however, when you click the button the url of this page changes to http://getbootstrap.com/customize/undefined/customize/?id=7258922, making the links to send you to http://getbootstrap.com/customize/undefined/getting-started, and, of course, there is no page there.

@cvrebert
Copy link
Collaborator

cvrebert commented Nov 1, 2013

@Studio384 I am unable to reproduce with Chrome on Mac. What web browser and OS (and versions) are you using?

@Studio384
Copy link
Author

Internet Explorer in Windows 8.1.

@cvrebert
Copy link
Collaborator

cvrebert commented Nov 1, 2013

If you could try and pinpoint where the JS that changes the URL goes awry, that would be most helpful.

@xt0rted
Copy link
Contributor

xt0rted commented Nov 1, 2013

The problem is with the use of window.location.origin in customizer.js#L59 which isn't available in IE.

This Stack Overflow question says to do something like this to support all browsers

if (!window.location.origin)
     window.location.origin = window.location.protocol+"//"+window.location.host;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants