Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom checkbox/radio focus outline misplaced in Firefox #20586

Closed
Macsch15 opened this issue Aug 26, 2016 · 2 comments
Closed

Custom checkbox/radio focus outline misplaced in Firefox #20586

Macsch15 opened this issue Aug 26, 2016 · 2 comments

Comments

@Macsch15
Copy link

Macsch15 commented Aug 26, 2016

Custom checkbox on "focus" state:
2016-08-26_16-18-00

Windows 10 x64 (1607)
Firefox 48.0.2
Bootstrap 4 Alpha 3

In *-webkit browsers is fine.

PS: This issue is also in Radios
2016-08-26_16-45-00

@cvrebert cvrebert changed the title Custom checkbox focus - misplaced border Custom checkbox/radio focus outline misplaced in Firefox Aug 27, 2016
@bardiharborow
Copy link
Member

Interestingly, I get no :focus border at all on Mac 10.11.5 Firefox 49.0b7, but it works perfectly on Mac 10.11.5 Chrome 53.0.2785.80.

@mdo mdo added the has-pr label Dec 25, 2016
@mdo
Copy link
Member

mdo commented Dec 25, 2016

In Edge and IE11 I'm seeing this as well, and it's due to some aggressive rounding of rem unit values there. Funnily enough there's that PR about the percentages and rounding in IE11, but never saw an issue there. This is the first time I'm seeing overzealous rounding.

Rather than try to deal with that, I'm moving to pixel units for this shadow/focus style. It's not infinitely scalable, but should get the job done without the side effects.

@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 25, 2016
mdo added a commit that referenced this issue Dec 25, 2016
Use pixels instead of rem units for focus box-shadow on custom controls so that IE11, Edge, and Win FF screw it up less
mdo added a commit that referenced this issue Dec 25, 2016
Use pixels instead of rem units for focus box-shadow on custom controls so that IE11, Edge, and Win FF screw it up less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants