-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dropdown JS with Prototype 1.7.0 [BUG] #8379
Comments
Using Prototype with Bootstrap is not officially supported. See the following part of v3's docs: |
He Chris, I found the same problem @issue #6921 "3.0 uses namespace var e = $.Event('hide.bs.' + this.type) That won't solve this issue with Prototype since jQuery will call the canonical event name 'hide' which will still conflict with the Prototype hide() method on the element. The event name itself needs to change, eg, 'bs:hide.' + this.type (to use Backbone-inspired namespacing)." why you don't use namespace like moos suggested (Backbone Namespacing)? Am 03.07.2013 um 18:35 schrieb Chris Rebert notifications@github.com:
|
Ask on the mailing list for help with implementation details like this. If you find a particular bug, open a new issue for that. Thanks! |
This makes it extremely hard for those of us trying to convert existing applications to Bootstrap and jQuery. Is there any hope of getting this fixed? |
just use a click event and add the "open" class to the dropdown container. Then you bypass all the trouble code. |
I can confirm that bs:hide would solve the issue.
@krazyjakee Can you explain this in more details. Thanks a lot. |
I found a work around to make it running without changing bootstrap: zikula/core@079df47 |
@phaidon Genius 👍 |
You may found here a complete explanation of this issue and a workaround that do not require patching any framework bootstrap included. |
Just a quick comment here - thanks to @dgervalle for his link which led me to the jsfiddle which worked up until bootstrap 3.1.1 (at least), but when I upgraded to 3.3 I needed to add jQuery.noConflict();
if (Prototype.BrowserFeatures.ElementExtensions) {
var pluginsToDisable = ['tab', 'collapse', 'dropdown', 'modal', 'tooltip', 'popover'];
var disablePrototypeJS = function (method, pluginsToDisable) {
var handler = function (event) {
event.target[method] = undefined;
setTimeout(function () {
delete event.target[method];
}, 0);
};
pluginsToDisable.each(function (plugin) {
jQuery(window).on(method + '.bs.' + plugin, handler);
});
};
disablePrototypeJS('show', pluginsToDisable);
disablePrototypeJS('hide', pluginsToDisable);
} |
Hi @patrickdavey! You appear to have posted a live example (http://fiddle.jshell.net/dgervalle/hhBc6/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:
You'll need to fix these errors and post a revised example before we can proceed further. (Please note that this is a fully automated comment.) |
Hi @patrickdavey! You appear to have posted a live example (https://fiddle.jshell.net/crwcbuuk/1/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:
You'll need to fix these errors and post a revised example before we can proceed further. (Please note that this is a fully automated comment.) |
hey guys,
I just tested bootstrap3.0 with Prototype 1.7. At the secound click the btn-group is setting to display none.
christian
The text was updated successfully, but these errors were encountered: