.divider-vertical

[peteruhnak]

Hi, has the .divider-vertical for navbars been dropped from bootstrap 3, or is it just a feature overlook? I don't see it in neither docs nor code.

[mdo]

It's been dropped.

[amejiarosario]

It is very useful! I wonder what was the reason it was dropped... It was not a good practice or something else?

[sirex]

+1 to return vertical divider back.

[FreeApophis]

+1 really don't understand why this was dropped without a reasonable alteranative.

[cvrebert]

@mdo I can't seem to find a statement of the reason why we dropped it?

[Jauny]

+1 on bringing this back!

[mdo]

To be honest, a 1px vertical line didn't seem like something we really needed to create for the masses. In many cases, adding left and right borders to the nav links is the best bet. At other times rolling something completely custom makes more sense given a project's style.

I'm still against re-adding it at this point.

[FreeApophis]

Sure, it is not a necessity, however since the vertical line needs to become a horizontal line when it is collapsing to the mobile interface, it is at least not a trivial thing. And the much more trivial "divider" for the drop down is still there.

If the divider could be more general and just adapts to be a vertical divider would be a simple option.

For consistency in the navigation there should be also the possibility to divide in a vertical way, not only horizontally.

[mjbates7]

+1 I agree, this would be good to have it back if possible

[chilladelia]

+1

[JasonHuangHuster]

+1

[NourSammour]

+1

[57u]

+1

If this is to be removed, then the regular .divider class should be removed too. It makes no sense to drop one and not the other, keep or drop the whole divider idea.

Personally I really find them useful - as mentioned above, they are used to great effect when resizing to xs views, where the dividers can be transformed into horizontal ones.

[lcnvdl]

+1

[FreeApophis]

So since there is such a demand, could you please reopen the ticket, or create a new one and post the link here, so you could at least reevaluate the decision, and then at least tell us why it was removed?

[mdo]

If this is to be removed, then the regular .divider class should be removed too. It makes no sense to drop one and not the other, keep or drop the whole divider idea.

It did at the time, @57u, because we began adding our own "dividers" to the navbar content via borders on navbar sub-components and what not. And we cannot remove the dropdown divider now because that would break backward compatibility. Can't do that until v4.

So since there is such a demand, could you please reopen the ticket, or create a new one and post the link here, so you could at least reevaluate the decision, and then at least tell us why it was removed?

A handful of people isn't much demand to us. I don't mean to sound snarky or asshole-ish, so please hear me out. The reason for removing it was stated above already—a 1px line is not difficult to add yourself. Add borders wherever you need them.

Come v4, I can imagine us revisiting this to not do borders, but instead use dividers for more utility across viewport ranges, finer tuning of spacing, etc. Until then, it's not likely to be re-added.

[ctsstc]

I was trying to find this and figured it wasn't in v3, as stated you should just style borders yourself and using a whole li element within a list doesn't make sense especially in terms of SEO, surely google knows to omit empty elements, but still a whole li element seems like overkill. This has changed my mind on how it should be now : )

[agalazis]

just DIY the old one xD eg. for navbar:
.navbar .divider-vertical {
height: 40px;
margin: 0 9px;
border-left: 1px solid #f2f2f2;
border-right: 1px solid #ffffff;
}
now you have it back!

[FreeApophis]

Thats wrong, won't work. Try it and look at it when the menu collapsed...

@mdo, you made a breaking API change for no reason, and this thread shows there is demand, it might be small, but it is there, and it makes your product breaking others work. As a library you should have good reasons for breaking changes. But you don't even know the reason for the removal.

This is the kind of library I will avoid in the future, because you never can be sure that the next update breaks your whole design. And your reaction shows, I need to search an alternative soon, because bootstrap should avoid work, and not add to the designers work.

[agalazis]

You are absolutely right!(it doesn't offer what botstrap is supposed to offer but you can build on it using javascript or css workarounds ) I also agree that they shouldn't remove it because it makes things complicated.

[mdo]

[Y]ou made a breaking API change for no reason

We've been very vocal about removing or changing things that break backward compatibility (with major releases). We document it in our readme. We tell folks about it in advance of new releases. We also have a pretty good track record of telling folks exactly why we remove things.

In this case, I saw no need to implement a vertical divider that:

• Duplicates the behavior and style of borders between navbar subcomponents (e.g., forms, navs, etc).
• Was most commonly used to imitate borders on navbar links instead of simply adding borders to the navbar anchors.

Moreover, this change happened five months ago. We've kind of passed the time for giving feedback on what makes it into v3, and as I stated above, I have no plans to re-implement this small of a change.

This thread shows there is demand, it might be small, but it is there, and it makes your product breaking others work.

I've already commented on the demand aspect. Like other feature requests with dozens of comments (hell, even hundreds of comments at times), if we don't want to add it, we won't. We listen to the needs of the community and try to provide the best solutions whenever possible.

However, we also are the ones that maintain this library, and if we don't want to add something as trivial as a divider, we won't. Again, I'm not trying to be an ass about this—it's purely matter of fact.

But you don't even know the reason for the removal.

Again, I've very clearly stated why (twice now).

Because you never can be sure that the next update breaks your whole design.

Breaking changes from major releases are to be expected. The web moves too fast to lock ourselves into incorrect changes or wrong decisions we made a year earlier. We will continue to break backward compatibility when it suites the wellbeing of the framework.

We also do our best to test things out and communicate as clearly as possible what's changed in a release. We callout gotchas, dependency updates, and more as much as possible. We do make mistakes though, and that's why we have bug reports.

And your reaction shows, I need to search an alternative soon, because bootstrap should avoid work, and not add to the designers work.

By that logic we should do anything and everything ever asked of us. And that's a bad argument, and it's something we'll never end up doing. Our goal is to help people build awesome shit on the internet. It's not our job to do every part of your work for you. Our job is to make it easier for you to do your job.

Obviously we should make it as easy as possible, but if you're blaming us for you having to add some borders to a framework that provides as much as we do, you might want to rethink your priorities. We don't solve every problem. We solve common problems to the best of our abilities.

This is the kind of library I will avoid in the future

Fine by me. That's no argument for making this divider come back, but if you feel it's enough to make you choose something else, I won't fight you on it. Thanks for having been a user this long <3.

[FreeApophis]

That is an answer we can live with. TY

[agalazis]

"Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software."

I think the above license allows the creation of other bootstrap forks, interesting... correct me if I am wrong.

[attatae]

+1. If we're using something like Bootstrap, it's to save time. Leaving the "1 px divider" option isn't something overly cluttering to the docs. And it's obviously tremendously helpful to a lot of people - they took the time to search for a solution, find something they were hoping for destroyed needlessly and carelessly, and came here to complain. If MDO would rather write a damn-near treatise on the divider issue, than just implement the thing, that is a downright shame.

[mdo]

If we're using something like Bootstrap, it's to save time.

Sure, but not having a 1px divider doesn't make Bootstrap save any less time than it already does.

Leaving the "1px divider" option isn't something overly cluttering to the docs.

Sure, but anything added dilutes everything else. We already have the borders between components, and as I said earlier, we cannot change that until v4.

And it's obviously tremendously helpful to a lot of people - they took the time to search for a solution,

Again, this isn't a lot of people. And they found what they were looking for—we removed the dividers and if you want them, you should add them on your own.

[They] find something they were hoping for destroyed needlessly and carelessly, and came here to complain.

This was not needlessly or carelessly destroyed. We removed it because we didn't have a use for them within Bootstrap. If it's not being actively used, why continue to support it? We switched models from explicit dividers as separate elements to implicit ones with borders on components.

If MDO would rather write a damn-near treatise on the divider issue, than just implement the thing, that is a downright shame.

When folks take the time to write responses without thoroughly reading earlier replies from myself or the core team, I'll do my best to address every single point possible to remedy that. I did it earlier, and I'm doing it again because folks keep rehashing the same things.

What's a downright shame is the attitude of "just implement the thing." That's a shitty outlook to any project and one that I'll never take, here or anywhere else. As maintainers it's our job to question every addition and deletion, trivial or complicated.

We love hearing from folks, and we always take that into consideration. However, for Bootstrap v3.x and this particular issue, we won't be adding anything.

[JamesWilsonNovel]

@mdo Thanks for taking the time to explain your reasons for dropping it. While I too used it, your hard work on Bootstrap has made my life so much easier that I can't complain about this one thing. Bootstrap is a Godsend

[j-walker23]

^!

[Oceanswave]

"To be honest, a 1px vertical line didn't seem like something we really needed to create for the masses."

Um, but yet the horizontal divider .divider still exists? Hmm.. flawed reasoning in one way or the other.

But, as with many things, now that mdo has stated his opinion, there's no going back...

+1 for its return anyway.

[j-walker23]

I to need a vertical divider but it doesn't matter, like @JamesWilsonVSolvit said bootstrap is a GODSEND. Using tools like bootstrap/angular save me hours every damn day lol.

[Oceanswave]

yep! don't disagree with you there j-walker -- just a quick 10 second fix for hours saved.

[andrewshawcare]

@mdo You're an exceptional communicator and I'm glad you're maintaining something I depend on.

[lbehnke]

+1 for dividers

[SergeyBarskiy]

I think this will bring it back in 3.0

.navbar .divider-vertical {
height: 50px;
margin: 0 9px;
border-right: 1px solid #ffffff;
border-left: 1px solid #f2f2f2;
}

.navbar-inverse .divider-vertical {
border-right-color: #222222;
border-left-color: #111111;
}

@media (max-width: 767px) {
.navbar-collapse .nav > .divider-vertical {
display: none;
}
}

[pengkong]

+1 to bring it back.

but also...

+1 to @mdo and the core team even if they don't bring it back.

[cjcruz]

+1 divider!!!

[carasmo]

It's unnecessary to add a divider, just create borders:

http://jsbin.com/heziw/1/edit

/* put in the breakpoint variable and make some new ones in your variables.less file */

@media (min-width:768px){

  .navbar-default .navbar-nav > li:not(:last-child) {
    border-right:1px solid #ddd;
   }

  .navbar-default .navbar-nav > li:not(:first-child) {
    border-left:1px solid #fff;
   }

  .navbar-inverse .navbar-nav > li:not(:last-child) {
    border-right:1px solid #000;
   }

  .navbar-inverse .navbar-nav > li:not(:first-child) {
    border-left:1px solid #444;
   }  


}

[FreeApophis]

Thats not even close to the functionality of the divider.

• The divider is specific and should divide different intents, not on every cell.
• The divider should divide the intents collapsed or otherwise

Yes of course it is possible to do it on our own. But thats obviously not the point.

[gubi]

+1

[asiniy]

+1

[balexandre]

👍

[chrisdrogaris]

+1

[zuphu]

+1

[askhat]

Get back the divider!

[hackhowtofaq]

+1

[FaroukBENGHARSSALLAH]

Just use it agin :D

[steelywing]

👍

[xandrco]

+1

[alexandregrin]

+1
We're not a handful. Maybe 0,1% of the people would write a comment. So we are a lot.

[mie]

please

[MarcMouallem]

+1

[oleg-codaio]

+1

[niknokseyer]

+1

[Vadorequest]

+1... Why remove something that so many users thing useful? Looks as much smart as Windows removing desktop menu for no real good reason.

[paustria]

+1