switch to grunt-css-flip for RTL CSS generation #12949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to have to completely disable |
|
Fine with me, but why don't you make the grunt plugin use case lip instead? |
|
@XhmikosR Underscores seem to be the convention in Grunt for some reason. |
…, for now Can't disable it just for the Gruntfile due to jscs-dev/node-jscs#287
|
I see... Maybe cssflip then? I'm saying this because the issue will be the same for everyone using the grunt plugin and camel case, which is very common. |
|
Yeah, definitely worth reconsidering in a future release. |
cvrebert
added a commit
that referenced
this pull request
Mar 6, 2014
switch to grunt-css-flip for RTL CSS generation
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.