Fix arrow colour on popover bottom

[mattbearman]

Before:

After:

Stop arrow from being white on bottom popover, as the arrow sits on the title bar, so should match the title bar's background colour.

[cvrebert]

Could you post a live example (e.g. JS Fiddle) that demonstrates the problem?

[cvrebert]

LESS requires parentheses around arithmetic expressions; this isn't compiling correctly currently.

[cvrebert]

Please include /dist/css/bootstrap.css in your pull request, so that we can see+check the generated CSS too.

[mattbearman]

Ah, didn't realise LESS is meant to have parentheses, it compiles fine on mine (less and jekyll-less ruby gems) I'll update that and include the generated CSS.

JSFiddles:
Current master - http://jsfiddle.net/5UAXa/1/
Fixed with my PR - http://jsfiddle.net/s8jqD/

[cvrebert]

Yeah, please use our Grunt task when building/testing for a pull request, to ensure that you're using the correct versions of everything.

[mdo]

It's meant to be white 😁.

[mattbearman]

Are honestly saying that when the popover is using the bottom positioning the arrow looks better white than grey?

I understand that when the popover is left, top or right the arrow should be white, because it matches the white of the popover body. But when bottom positioned, the arrow sits above the title bar, which is grey, so the white arrow doesn't look as good.

I've just noticed - look at this conversation, the arrow that points to my face is grey, to match the title bar, bootstrap's popovers would look better if they did the same.

[hnrch02]

Well, but not every popover is required to have a title bar, so it then would look bad if the arrow was gray and no title bar was present.

[mattbearman]

Hmm, now that is a good point, I suppose you could have an additional class to make the popover's arrow grey for when it's positioned bottom with a title?

[hnrch02]

I guess we could kinda override the white triangle with a gray one, like this, but it seems to be a rather hacky solution...

[mdo]

I've just noticed - look at this conversation, the arrow that points to my face is grey, to match the title bar, bootstrap's popovers would look better if they did the same.

Yup, I designed both :). The Bootstrap popover is meant to tie into the inner border on popovers. Look closely and you'll see a 1px white inner border (set with padding). Subtle, but the colors make sense given that, and the optional header.