[Fix Issue #15691] .form-control-static changes height when empty

[kkirsche]

[Fix Issue #15691] .form-control-static changes height when empty by setting the minimum height to the size it is when text is in the .form-control-static

JSFiddle: http://jsfiddle.net/4pdo4yzo/

[mdo]

The value of 34px needs to be calculated based on the font-size, line-height, etc. I'm out of town right now, but if you don't get to it, I probably can next week.

[kkirsche]

Calculating it now with line height and font-size-base. Thanks for your feedback

[cvrebert]

Do we need to do anything extra to cover the .form-group-* cases too? (e.g.

bootstrap/less/forms.less

Line 321 in 85a6595

.form-control-static {

)

[kkirsche]

I don't believe so @cvrebert but I'd love to hear from others if they think so.

My logic for why it wouldn't be necessary is that as the .form-group-* cases are not overriding or declaring a min-width value, the declaration for all .form-control-static, which the min-height was set on in this, should apply to those further down the line.

[kkirsche]

Modified the jsfiddle to show what I mean:

http://jsfiddle.net/m7vnxh7u/

EDIT: Nevermind, I see why we would want it on those. I'll make those changes 👍

[twbs-lmvtfy]

Hi @kkirsche!

You appear to have posted a live example (http://fiddle.jshell.net/m7vnxh7u/show/light/), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

• line 51, column 3: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
• line 52, column 3: E014: Columns (.col-*-*) can only be children of .rows or .form-groups

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!

(Please note that this is a fully automated comment.)

[kkirsche]

Fixed. Good catch, I messed up the logic behind this as it should be different for each version of the form-group to adjust for the different font-sizes of each .form-group-* type

[kkirsche]

Squashed commits into single due to small size of this change and it seems to have stabilized in regards to feedback.

[kkirsche]

Just wanted to follow up on this and see if anything was missing.

[kkirsche]

Wanted to follow up about this and just check if anything else was necessary. Thanks for your time guys 👍

[mdo]

[cvrebert]

Will merge this ASAP; I just need to rebase it to adjust the commit message.

[kkirsche]

Rebased and fixed @cvrebert

[cvrebert]

@kkirsche Thanks man!