Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility and headings hierarchy for the CSS page. #15948

Closed
wants to merge 2 commits into from
Closed

Accessibility and headings hierarchy for the CSS page. #15948

wants to merge 2 commits into from

Conversation

StevenBlack
Copy link
Contributor

Just a few adjustments here.

Below are the before-and-afters for all the changes in this PR.

bs-css

bs-css2

@kkirsche
Copy link
Contributor

kkirsche commented Mar 1, 2015

Thanks for your hard work on this/these. I personally like the changes you've made 👍

@StevenBlack
Copy link
Contributor Author

aw... thanks @kkirsche!

BTW, how can I learn more about what's cooking in v. 4?

@kkirsche
Copy link
Contributor

kkirsche commented Mar 1, 2015

@StevenBlack honestly I don't know. It's kind of a secret between the owners, admins and collabs. 😃 Sorry! Wish I knew as I would love to try to contribute to it and help out with it

@XhmikosR
Copy link
Member

XhmikosR commented Mar 2, 2015

@cvrebert @patrickhlauke: LGTM, any objections before merging this?

@cvrebert
Copy link
Collaborator

cvrebert commented Mar 2, 2015

None from me.

@XhmikosR
Copy link
Member

XhmikosR commented Mar 2, 2015

Actually, @StevenBlack has made quite a few PR on this matter so we should merge all of them. As far as I can tell, they all look good.

@patrickhlauke
Copy link
Member

:shipit:

@XhmikosR XhmikosR closed this in 20d3ad1 Mar 3, 2015
@cvrebert cvrebert mentioned this pull request Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants