Fixed proper navigation element selection on backward scrolling (from the bottom to the top) #16043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the bottom to the top)
|
Tests passed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: CONFIRMED Commit: 8337173 (Please note that this is a fully automated comment.) |
|
I've confirmed that the new unit test correctly fails when the included fix is reverted. |
|
@cvrebert thanks for immediate response. |
|
You welcome. |
cvrebert
added a commit
that referenced
this pull request
Mar 15, 2015
ScrollSpy: Fixed proper nav element selection when scrolling upwards
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found scrollspy issue.
It was selecting wrong navigation element. Wrong behavior were produced by unnecessary equal sign on line 99 (comparison of target offsets)