Update bower.json to comply with new spec for `main` #16359

Merged
merged 2 commits into from Apr 24, 2015

Conversation

Projects
None yet
9 participants
@cvrebert
Member

cvrebert commented Apr 24, 2015

This updates our bower.json to comply with the new, long-awaited, more detailed spec for the main field of bower.json. See bower/spec#43

If you have a complaint about this, take it up with the Bower folks, not us:
https://github.com/bower/bower.json-spec/issues
Or consider using a different package manager.

cvrebert added some commits Apr 24, 2015

bower.json: Remove font files from `main`
Per bower/spec#43 :
> font files [...] are not `main` files as they are not entry-points.

If you have a complaint about this, take it up with the Bower folks:
https://github.com/bower/bower.json-spec/issues
bower.json: Remove bootstrap.css from `main`
Per bower/spec#43 :
> Use source files with module exports and imports over pre-built distribution files.

Also, the example in that PR doesn't include
/dist/movement.css or /dist/movement.min.css
in its `main`.

If you have a complaint about this, take it up with the Bower folks:
https://github.com/bower/bower.json-spec/issues

@cvrebert cvrebert added the meta label Apr 24, 2015

@cvrebert cvrebert added this to the v3.3.5 milestone Apr 24, 2015

@twbs twbs locked and limited conversation to collaborators Apr 24, 2015

cvrebert added a commit that referenced this pull request Apr 24, 2015

Merge pull request #16359 from twbs/bower
Update bower.json to comply with new spec for `main`

@cvrebert cvrebert merged commit 1c57181 into master Apr 24, 2015

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@cvrebert cvrebert deleted the bower branch Apr 24, 2015

@cvrebert

This comment has been minimized.

Show comment
Hide comment
@cvrebert

cvrebert Jun 20, 2015

Member

See #16663 for further discussion.

Member

cvrebert commented on 3886198 Jun 20, 2015

See #16663 for further discussion.

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jul 29, 2015

Member

Agreed, in hindsight we should've communicated this better and bumped the minor version. Apologies for the ongoing hiccup folks <3.

Member

mdo replied Jul 29, 2015

Agreed, in hindsight we should've communicated this better and bumped the minor version. Apologies for the ongoing hiccup folks <3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.