New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies and gems. #25192

Merged
merged 3 commits into from Jan 11, 2018

Conversation

Projects
None yet
3 participants
@XhmikosR
Member

XhmikosR commented Jan 3, 2018

@mdo: just for a confirmation since I don't have a Mac rig, can you:

  1. Download the latest node.js 8.9.4
  2. check out this branch
  3. do npm i

and see if package-lock.json is modified? it shouldn't be anymore.

@XhmikosR XhmikosR requested a review from mdo Jan 3, 2018

@XhmikosR XhmikosR added build v4 labels Jan 3, 2018

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jan 3, 2018

Member

Just updated to 8.9.4 and ran npm i—the package-lock.json was modifier for dozens of entries. All of them around the integrity value.

Member

mdo commented Jan 3, 2018

Just updated to 8.9.4 and ran npm i—the package-lock.json was modifier for dozens of entries. All of them around the integrity value.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 4, 2018

Member

Hmmm, that is something else I guess. The previous issue was with fsevents.

Member

XhmikosR commented Jan 4, 2018

Hmmm, that is something else I guess. The previous issue was with fsevents.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 4, 2018

Member

@mdo: how about removing the local node_modules folder and doing npm i?

Member

XhmikosR commented Jan 4, 2018

@mdo: how about removing the local node_modules folder and doing npm i?

@mdo

This comment has been minimized.

Show comment
Hide comment
@mdo

mdo Jan 8, 2018

Member

Sorry, missed your follow-up reply. I'll try again tonight.

Member

mdo commented Jan 8, 2018

Sorry, missed your follow-up reply. I'll try again tonight.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 9, 2018

Member

Hmm, Travis failures seem unrelated to these changes. /CC @Johann-S

Member

XhmikosR commented Jan 9, 2018

Hmm, Travis failures seem unrelated to these changes. /CC @Johann-S

@Johann-S

This comment has been minimized.

Show comment
Hide comment
@Johann-S

Johann-S Jan 9, 2018

Member

Seems related to Travis and the ability to launch Chrome Headless 😟

Member

Johann-S commented Jan 9, 2018

Seems related to Travis and the ability to launch Chrome Headless 😟

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 9, 2018

Member

Yeah, that was my understanding too :/ I don't see any issue reported https://github.com/travis-ci/travis-ci/issues the last days, so i triggered a rebuild and if it fails we should open an issue there.

Member

XhmikosR commented Jan 9, 2018

Yeah, that was my understanding too :/ I don't see any issue reported https://github.com/travis-ci/travis-ci/issues the last days, so i triggered a rebuild and if it fails we should open an issue there.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 9, 2018

Member

All right, I made travis-ci/travis-ci#9024.

Member

XhmikosR commented Jan 9, 2018

All right, I made travis-ci/travis-ci#9024.

XhmikosR added some commits Jan 11, 2018

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR
Member

XhmikosR commented Jan 11, 2018

@mdo @Johann-S ping.

@mdo mdo referenced this pull request Jan 11, 2018

Closed

v4.0.0 ship list #25098

@XhmikosR XhmikosR merged commit bfceedc into v4-dev Jan 11, 2018

3 checks passed

bundlesize Good job! bundle size < maxSize
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@XhmikosR XhmikosR deleted the v4-dev-xmr-bump-deps-gems branch Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment