Update devDependencies and gems. #25192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just updated to 8.9.4 and ran |
|
Hmmm, that is something else I guess. The previous issue was with fsevents. |
|
@mdo: how about removing the local node_modules folder and doing |
XhmikosR
force-pushed
the
v4-dev-xmr-bump-deps-gems
branch
2 times, most recently
from
8c1f9ef
to
6237e66
Compare
|
Sorry, missed your follow-up reply. I'll try again tonight. |
XhmikosR
force-pushed
the
v4-dev-xmr-bump-deps-gems
branch
from
6237e66
to
d690caf
Compare
|
Hmm, Travis failures seem unrelated to these changes. /CC @Johann-S |
|
Seems related to Travis and the ability to launch Chrome Headless 😟 |
|
Yeah, that was my understanding too :/ I don't see any issue reported https://github.com/travis-ci/travis-ci/issues the last days, so i triggered a rebuild and if it fails we should open an issue there. |
|
All right, I made travis-ci/travis-ci#9024. |
XhmikosR
force-pushed
the
v4-dev-xmr-bump-deps-gems
branch
2 times, most recently
from
16637aa
to
769df1f
Compare
XhmikosR
force-pushed
the
v4-dev-xmr-bump-deps-gems
branch
from
769df1f
to
38a0924
Compare
Johann-S
approved these changes
Jan 11, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdo: just for a confirmation since I don't have a Mac rig, can you:
npm iand see if package-lock.json is modified? it shouldn't be anymore.