Revert "Remove custom example plugin."

[XhmikosR]

This reverts commit d01b4eb (PR #25784).

This implementation has many limitations/issues.

Closes #27395

[mdo]

Is this just the holder.js stuff or something else as well? I imagine we could replace holder.js with some SVGs, 1x1 GIFs, etc?

[XhmikosR]

Yup, mostly holder.js. I also suggested SVGs in #27395 but I didn't see any traction. Plus Liquid does not do regular expressions so this cannot be extended any more than exact matches...

All this will be useless with Hugo anyway, but since I don't know when I'll get to finish that, you know.

[m5o]

I don't see these many limitations/issues, to be honest. There is one issue, to be precise.

Isn't the real question to ask, what's the main focus of the html markup example? It's primarly showing and teaching the element structure and bootstrap class naming. The src of the image is secondary.

There are some image placeholder services available with a similar url structure as holder.js. Easiest would, replace it by e.g. //imgplaceholder.com instead of ... ✌️

[XhmikosR]

Well we are not tied to any solution. I just need something that works properly and the current solution does not. It's so simple.

[XhmikosR]

Putting this on hold for now. I still don't care about using the plugin or not as long as it works for our needs. That being said, it's a good chance to replace holder.js with pure SVGs.

[mdo]

Removed from v4.2 given the hold.

Edit: Doh, missed the unlock!

[XhmikosR]

The lock was when there was that github issue and I was getting repeated comments about the same thing. I unlocked it after it was resolved as you can see.

…

On Sat, Nov 3, 2018, 20:36 Mark Otto ***@***.*** wrote: Removed from v4.2 given the hold. Next time, let's put it on hold and not lock the conversation here. No need to do that as it sends the wrong message after receiving feedback—dissenting opinions are fine, even if they trigger notifications. :D — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27491 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtQc5haBTOwD3rUtLeigW9aUvCTQUks5ureIcgaJpZM4XybfN> .