Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4-dev backports and dep updates #28589

Merged
merged 11 commits into from
Apr 29, 2019
Merged

v4-dev backports and dep updates #28589

merged 11 commits into from
Apr 29, 2019

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 1, 2019

No description provided.

@XhmikosR XhmikosR added the v4 label Apr 1, 2019
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-backports branch 4 times, most recently from 86e061e to 7979460 Compare April 5, 2019 08:55
* Fix buttons :focus state styles

Buttons :hover and :focus state shares styles.
Buttons :focus text color on 'a.btn' is now consistent with others '.btn'.

* `:focus` styles should be in sync with `.focus`.

So shared styles with hover were copy to focus definition. Rather then using
`hover-focus` mixin which do not contain `.focus`.
@XhmikosR XhmikosR changed the title v4-dev backports v4-dev backports and dep updates Apr 5, 2019
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-backports branch 2 times, most recently from a243072 to e183643 Compare April 9, 2019 12:13
@XhmikosR XhmikosR marked this pull request as ready for review April 9, 2019 12:27
@XhmikosR XhmikosR requested review from a team as code owners April 9, 2019 12:27
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-backports branch 3 times, most recently from da13742 to 39a98f0 Compare April 13, 2019 11:52
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-backports branch 4 times, most recently from 24ab3cc to 84416f9 Compare April 15, 2019 08:44
Extrapolates the previously used selector into a new mixin that only generates valid CSS by creating psuedo-classes for `valid` and `invalid`, and nothing else.

Fixes #28380.
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-backports branch 2 times, most recently from bf0cc24 to 61e6d45 Compare April 29, 2019 13:45
@XhmikosR
Copy link
Member Author

XhmikosR commented Apr 29, 2019

I'm think I'm gonna merge this as is and we do the jQuery update when they release v3.4.1.

/CC @MartijnCuppens @Johann-S @mdo for approval

Also, fix the `update-deps` excludes and add karma since 4.x requires Node.js >= 8.
@XhmikosR XhmikosR merged commit 7da9729 into v4-dev Apr 29, 2019
@XhmikosR XhmikosR deleted the v4-dev-xmr-backports branch April 29, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants