Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress focus outline for buttons when it shouldn't be visible in Chromium #32689

Merged
merged 3 commits into from
Jan 10, 2021
Merged

Suppress focus outline for buttons when it shouldn't be visible in Chromium #32689

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac85fdb
Suppress focus outline for buttons when it shouldn't be visible in Ch…
patrickhlauke Jan 6, 2021
6fdea15
Merge branch 'main' into patrickhlauke-button-focus-fix
patrickhlauke Jan 9, 2021
a103140
Merge branch 'main' into patrickhlauke-button-focus-fix
XhmikosR Jan 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scss/_reboot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,15 @@ button {
border-radius: 0;
}

// Explicitly remove focus outline in Chromium when it shouldn't be
// visible (e.g. as result of mouse click or touch tap). It already
// should be doing this automatically, but seems to currently be
// confused and applies its very visible two-tone outline anyway.

button:focus:not(:focus-visible) {
outline: 0;
patrickhlauke marked this conversation as resolved.
Show resolved Hide resolved
}

// 1. Remove the margin in Firefox and Safari

input,
Expand Down