Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent toast autohiding if focusing or hovering #33221

Merged
merged 2 commits into from
May 11, 2021
Merged

Prevent toast autohiding if focusing or hovering #33221

merged 2 commits into from
May 11, 2021

Conversation

RyanBerliner
Copy link
Contributor

@RyanBerliner RyanBerliner commented Feb 28, 2021 •
edited by XhmikosR
Loading

resolves #32820

TODO:

  • Land it after some of the refactoring PRs so that we don't need to adapt bundlewatch

@RyanBerliner RyanBerliner requested a review from a team as a code owner February 28, 2021 20:33
@RyanBerliner RyanBerliner force-pushed the toast-interaction branch 2 times, most recently from 128b504 to 2a63a7b Compare March 19, 2021 20:19
GeoSot
GeoSot reviewed Mar 23, 2021
View reviewed changes
js/src/toast.js Outdated Show resolved Hide resolved
js/src/toast.js Outdated Show resolved Hide resolved
js/src/toast.js Outdated Show resolved Hide resolved
js/src/toast.js Show resolved Hide resolved
patrickhlauke
patrickhlauke requested changes Apr 9, 2021
View reviewed changes
js/tests/unit/toast.spec.js Outdated Show resolved Hide resolved
js/tests/unit/toast.spec.js Outdated Show resolved Hide resolved
GeoSot
GeoSot requested changes Apr 10, 2021
View reviewed changes
js/src/toast.js Outdated Show resolved Hide resolved
GeoSot
GeoSot reviewed Apr 13, 2021
View reviewed changes
js/src/toast.js Show resolved Hide resolved
js/tests/unit/toast.spec.js Show resolved Hide resolved
js/tests/unit/toast.spec.js Show resolved Hide resolved
@GeoSot GeoSot self-requested a review April 26, 2021 22:33
@GeoSot
Copy link
Member

GeoSot commented May 10, 2021

@RyanBerliner please rebase your branch.

@XhmikosR XhmikosR changed the title prevent toast autohiding if focusing or hovering Prevent toast autohiding if focusing or hovering May 11, 2021
@XhmikosR XhmikosR merged commit 9c3ab65 into twbs:main May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpadev alpadev alpadev left review comments

@GeoSot GeoSot GeoSot approved these changes

@patrickhlauke patrickhlauke patrickhlauke approved these changes

Assignees
No one assigned
Labels
js v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toasts should not autohide when hovered or when focus is inside
5 participants
@RyanBerliner @GeoSot @patrickhlauke @alpadev @XhmikosR