Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of .list-group-item-action #35759

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Fix position of .list-group-item-action #35759

merged 1 commit into from
Feb 9, 2022

Conversation

WinterSilence
Copy link
Contributor

<style>
.list-group-item-action {color: blue;}
.list-group-item {color: red;}
</style>
<p class="list-group-item">red text!</p>
<p class="list-group-item list-group-item-action">still red text!</p>

because .list-group-item declared after .list-group-item-action (order in attribute class no effect)

@WinterSilence WinterSilence requested a review from a team as a code owner January 31, 2022 21:54
@WinterSilence WinterSilence changed the title Fix overriding styles of .list-group-item-action Fix position of .list-group-item-action Jan 31, 2022
@WinterSilence
Copy link
Contributor Author

@mdo review PR please

Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, nice catch!
Thanks.

@ffoodd
Copy link
Member

ffoodd commented Feb 3, 2022

@ mdo review PR please

There's no urge, please don't ping people.

@ffoodd
Copy link
Member

ffoodd commented Feb 8, 2022

@WinterSilence it's already approved, please stop pingging.

@WinterSilence
Copy link
Contributor Author

@ffoodd sorry, apparently accidentally clicked

~~~html
<style>
.list-group-item-action {color: blue;}
.list-group-item {color: red;}
</style>
<p class="list-group-item">red text!</p>
<p class="list-group-item list-group-item-action">still red text!</p>
~~~
because `.list-group-item` declared after `.list-group-item-action` (order in attribute `class` no effect)
@mdo mdo merged commit 761c4ff into twbs:main Feb 9, 2022
@WinterSilence WinterSilence deleted the patch-6 branch February 9, 2022 07:46
mdo added a commit that referenced this pull request Mar 14, 2022
@mdo mdo mentioned this pull request Mar 14, 2022
mdo added a commit that referenced this pull request Mar 17, 2022
mdo added a commit that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants