-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use child combinators to avoid inheriting parent accordion's flush styles #37508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good by me if you agree @julien-deramond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found no regression by testing different nesting and regular use cases. LGTM! Thanks for the PR!
…wbs#37508) Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk> Co-authored-by: Julien Déramond <juderamond@gmail.com>
Description
Use child combinators to avoid inheriting parent accordion's flush styles
Motivation & Context
Fixes #37455
Type of changes
Checklist
npm run lint
)Live previews
No changes in documentation
https://deploy-preview-37508--twbs-bootstrap.netlify.app/docs/5.3/components/accordion/
Code Pen
https://codepen.io/nkdas91/pen/VwdMXVm
Related issues
#37455