Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color mode: proposal to handle color mode for components #38917

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 17, 2023

Description

Add some cases to color-mode mixin in order to allow using on each component.
The proposed solution is maybe far from ideal but before going deeper, I'd like to have some feedback on something like this.
Not quite sure it's breaking since it might be an internal mixin.

Motivation & Context

Be able to introduce the use of data-bs-theme=dark on every component (Not implemented in this PR apart the one already implemented).

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

and some docs.

Related issues

Closes #38853.
Might superseed #38807.

@louismaximepiton louismaximepiton marked this pull request as ready for review July 18, 2023 09:07
@louismaximepiton louismaximepiton requested a review from a team as a code owner July 18, 2023 09:07
@tagliala
Copy link
Contributor

Might close or help on #38853.

It appears to fix #38853

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

btn-close: dark mode data attribute only works when on parent, not when on button directly
2 participants