Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: update navbar in visual modal test #39294

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

julien-deramond
Copy link
Member

Description

This PR updates the navbar used in our modal visual test which still use old .navbar-full and .hidden-lg-up classes, and so never render the content of the navbar.

For context, .hidden-lg-up and .navbar-full were removed after v4.0.0 alpha versions.

Their usage was the following:

The .hidden-*-up classes hide the element when the viewport is at the given breakpoint or wider. For example, .hidden-md-up hides an element on medium, large, and extra-large viewports.

Corresponding code in bootstrap.css in v4.0.0-alpha.5

@media (min-width: 992px) {
  .hidden-lg-up {
    display: none !important;
  }
}

that I've changed to our .navbar-expand-lg which does the same thing:

@media (min-width: 992px) {
.navbar-expand-lg .navbar-toggler {
    display: none;
  }
}

Regarding .navbar-full, IMO we can just drop it as it's already handled by our .navbar-* classes:

.navbar-full {
  z-index: 1000;
}

@media (min-width: 576px) {
  .navbar-full {
    border-radius: 0;
  }
}

The global modification of the navbar follows our current navbar documentation and usage.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (N/A) My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live preview

@julien-deramond julien-deramond merged commit ce11411 into main Oct 13, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-js-test-visual-modal branch October 13, 2023 08:28
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants