Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing data-bs-theme="light" in navbars color schemes markup #40504

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 29, 2024

Description

This PR adds the missing data-bs-theme="light" data attribute in the last example of the navbars color schemes at https://getbootstrap.com/docs/5.3/components/navbar/#color-schemes.

The executed code contained it, but not the copyable markup.

Type of changes

  • Documentation fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Discussed in #39989 (comment)

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@julien-deramond julien-deramond merged commit d6731ea into main May 29, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-jd-missing-data-bs-theme-light-in-navbars branch May 29, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants